Folding: output the relaxed extended instances #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful information to pass to the IVC circuit. I would suggest to improve the interface later. Adding also documentation. Regarding the usage of `clone`, I am not happy with it. It will imply a possible non-negligeable memory overhead. We should avoid this when the first version is released.
dannywillems
commented
May 30, 2024
| @@ -385,7 +385,11 @@ fn test_decomposable_folding() { | |||
| let FoldingOutput { | |||
| folded_instance, | |||
| folded_witness, | |||
| .. | |||
| t_0: _, | |||
There was a problem hiding this comment.
It is a personal taste to explicitly unwrap it totally. It might be a pain when we add a field, but it gives information on the API. If there are many changes when unwrapping a structure, it means the API is not well implemented.
fabrizio-m
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful information to pass to the IVC circuit. I would suggest to improve the interface later.
Adding also documentation.
Regarding the usage of
clone, I am not happy with it. It will imply a possible non-negligeable memory overhead. We should avoid this when the first version is released.