Folding: make the variable name more explicits #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ins_i and wit_i variable names are reused. However, their semantics changed when called compute_extension on the environment. The values contain the commitments/evaluations added by quadriticization. In a future PR, the values will be returned as part of the folded output to pass them to the IVC circuit.
It seems that `cargo +nightly fmt` is not always stable. It doesn't remove duplicated import for instance.
fabrizio-m
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ins_i and wit_i variable names are reused. However, their semantics changed when
called compute_extension on the environment. The values contain the
commitments/evaluations added by quadriticization.
In a future PR, the values will be returned as part of the folded output to pass
them to the IVC circuit.