add doc about degree 3 folding #2243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
requested changes
May 20, 2024
There was a problem hiding this comment.
@fabrizio-m could you please add all the equations to the doc here? Like how we compute these t_0 and t_1 especially.
|
@fabrizio-m: we can discuss about this tomorrow at the offsite. I am happy to guide you on this. We should go through the codebase and the equations together. |
10 tasks
querolita
reviewed
May 29, 2024
| @@ -20,7 +20,37 @@ | |||
| //! expressions in orther to support multiple constraints. | |||
| //! That results in 2 errors terms t_0 and t_1 and a slightly different computation | |||
|
Most of the work in #2259 has been done by Fabrizio, I was guided by his explanation and he answered my questions. I would suggest closing this one, and move on with 2259. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.