MSM: introduce different lookup tables used by the serialization #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/msm-add-lookup-tables-for-serialization
branch
from
9436cef to
d0f6fef
Compare
dannywillems
requested review from
volhovm and
querolita
and removed request for
volhovm
volhovm
approved these changes
Mar 7, 2024
| @@ -6,6 +10,20 @@ pub mod constraints; | |||
| pub mod interpreter; | |||
| pub mod witness; | |||
|
|
|||
| pub enum LookupTable { | |||
There was a problem hiding this comment.
I would also want to discuss these interfaces at some point, they're all different in kimchi/mips and not always intuitive IMO. Like I would assume LookupTable is the actual /table/, like the data. What this is is more of a... enum of concrete types? SerializationLookupTables? just LookupTables? LookupTableIDs? I don't have a better name :(
There was a problem hiding this comment.
I also want to change later. Let's keep it in mind for when all circuits are defined and working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.