Interpreter: add bitmask to extract bits from foreign field limbs #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/serializer-env-add-bitmask
branch
from
e551aad to
4c87d1b
Compare
volhovm
approved these changes
Feb 28, 2024
| /// Extract the bits from the variable `x` between `highest_bit` and `lowest_bit`, and store | ||
| /// the result in `position`. | ||
| /// `lowest_bit` becomes the least-significant bit of the resulting value. | ||
| fn bitmask( |
There was a problem hiding this comment.
Maybe I don't exactly get the plan, but do we plan to implement another instance of InterpreterEnv? If not, what's the value of the trait if it's very tailored to the implementation and has exactly one?..
| position: Self::Position, | ||
| ) -> Self::Variable { | ||
| let x: u128 = *x; | ||
| let res = (x >> lowest_bit) & ((1 << (highest_bit - lowest_bit)) - 1); |
There was a problem hiding this comment.
Always confused about +-1 in the semantics of shifts, aside from that seems correct
Base automatically changed from
dw/serializer-define-column-structure
to
master
February 28, 2024 14:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests coming in 2 or 3 PRs