Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the column structure #1862

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dannywillems
Copy link
Member

No description provided.

@@ -30,6 +30,24 @@ impl<const N: usize, Fp: Field> InterpreterEnv for Env<N, Fp> {
}
}

impl<const N: usize, Fp: Field> Env<N, Fp> {
pub fn write_column(&mut self, position: Column, value: u128) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly like get_column in ColumnEnvironment implementation we discussed yesterday :) Could be cool to generalize it with some indexer/what Anais wrote, to avoid these multiple-ifs. Not at all urgent though.

Base automatically changed from dw/add-some-methods-in-env-witness to master February 28, 2024 14:13
@dannywillems dannywillems merged commit 38fa07e into master Feb 28, 2024
8 checks passed
@dannywillems dannywillems deleted the dw/serializer-define-column-structure branch February 28, 2024 14:13
@dannywillems dannywillems added the enhancement New feature or request label Mar 7, 2024
@dannywillems dannywillems self-assigned this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants