o1vm/pickles: Don't forget the extra columns

o1-labs · Oct 17, 2024 · 6db3291 · 6db3291
1 parent 20624f1
commit 6db3291
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/o1vm/src/pickles/column_env.rs b/o1vm/src/pickles/column_env.rs
@@ -36,8 +36,8 @@ pub struct ColumnEnvironment<'a, F: FftField> {
 }
 
 pub fn get_all_columns() -> Vec<Column> {
-    let mut cols = Vec::<Column>::with_capacity(SCRATCH_SIZE + N_MIPS_SEL_COLS);
-    for i in 0..SCRATCH_SIZE {
+    let mut cols = Vec::<Column>::with_capacity(SCRATCH_SIZE + 2 + N_MIPS_SEL_COLS);
+    for i in 0..SCRATCH_SIZE + 2 {
         cols.push(Column::Relation(i));
     }
     for i in 0..N_MIPS_SEL_COLS {

diff --git a/o1vm/src/pickles/tests.rs b/o1vm/src/pickles/tests.rs
@@ -74,12 +74,6 @@ fn test_regression_selectors_for_instructions() {
 
 #[test]
 fn test_small_circuit() {
-    /*   domain: EvaluationDomains<G::ScalarField>,
-       srs: &SRS<G>,
-       inputs: ProofInputs<G>,
-       constraints: &[E<G::ScalarField>],
-       rng: &mut RNG,
-    */
     debug!("0");
     let domain = EvaluationDomains::<Fq>::create(8).unwrap();
     let srs = SRS::create(8);
@@ -131,7 +125,7 @@ fn test_small_circuit() {
     };
     debug!("1");
     let mut expr = Expr::literal(Fq::zero());
-    for i in 0..SCRATCH_SIZE {
+    for i in 0..SCRATCH_SIZE + 2 {
         expr += Expr::cell(Column::Relation(i), CurrOrNext::Curr);
     }
     expr *= Expr::cell(Column::DynamicSelector(0), CurrOrNext::Curr);