Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devshell for macos #1976

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Fix devshell for macos #1976

merged 10 commits into from
Jan 23, 2025

Conversation

Geometer1729
Copy link
Member

@Geometer1729 Geometer1729 commented Jan 21, 2025

nix develop '.?submodules=1#default' should now work on macos.
Flake registries seem to be unreliable so this is recommended over nix develop o1js
This is useful because the previous work around of using the mina devshell relies on the PLONK_WASM_NODEJS and PLONK_WASM_WEB variables which skip some rust rebuilds unless the devshell itself is rebuilt.

nix run .?submodules=1#update-bindings still doesn't work on macos.

There are also nix documentation improvements from @hattyhattington17

Sorry for the large flake.nix diff, I also formatted it to improve readability.

@Geometer1729 Geometer1729 marked this pull request as ready for review January 21, 2025 17:23
@Geometer1729 Geometer1729 requested a review from a team as a code owner January 21, 2025 17:23
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Geometer1729 Geometer1729 merged commit 8ef36d1 into main Jan 23, 2025
31 checks passed
@Geometer1729 Geometer1729 deleted the brian/macos-fix branch January 23, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants