Resurrecting lookups PR: Add table ID collision assertions #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
force-pushed
the
volhovm/mina14674-resurrect-lookups-pr-chunk2
branch
from
1805fcd to
61e94f5
Compare
volhovm
force-pushed
the
volhovm/mina14674-resurrect-lookups-pr-chunk2
branch
from
61e94f5 to
253f4e2
Compare
mitschabaude
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings updates from the downstream:
I don't think it should
o1jsin terms of logic since the PR doesn't change any datatypes, but only the deep underlying logic.