Merge pull request #260 from o1-labs/feature/no-shifted-scale

Efficient scalar mul and other Scalar improvements
o1-labs · Apr 16, 2024 · ce6bf1d · ce6bf1d
2 parents a585a31 + a4dd716
commit ce6bf1d
Show file tree

Hide file tree

Showing 7 changed files with 89,885 additions and 89,900 deletions.
diff --git a/MINA_COMMIT b/MINA_COMMIT
@@ -1,2 +1,2 @@
 The mina commit used to generate the backends for node and web is
-88822f9ec1e329e5cd12821e0541bf070ca2c66b
+dab6eb3b9529e91a9fde14563a0d3f6726f86772
diff --git a/compiled/node_bindings/o1js_node.bc.cjs b/compiled/node_bindings/o1js_node.bc.cjs
diff --git a/compiled/node_bindings/o1js_node.bc.map b/compiled/node_bindings/o1js_node.bc.map
diff --git a/compiled/web_bindings/o1js_web.bc.js b/compiled/web_bindings/o1js_web.bc.js
diff --git a/crypto/elliptic-curve.ts b/crypto/elliptic-curve.ts
@@ -11,6 +11,7 @@ import {
 import { Endomorphism } from './elliptic-curve-endomorphism.js';
 export {
   Pallas,
+  PallasAffine,
   Vesta,
   CurveParams,
   GroupAffine,
@@ -505,6 +506,17 @@ function affineScale(g: GroupAffine, s: bigint | boolean[], p: bigint) {
 
 type CurveAffine = ReturnType<typeof createCurveAffine>;
 
+const PallasAffine = createCurveAffine({
+  name: 'Pallas',
+  modulus: p,
+  order: q,
+  generator: pallasGeneratorProjective,
+  b,
+  a,
+  endoBase: pallasEndoBase,
+  endoScalar: pallasEndoScalar,
+});
+
 function createCurveAffine({
   name,
   modulus: p,

diff --git a/ocaml/lib/snarky_bindings.ml b/ocaml/lib/snarky_bindings.ml
@@ -376,9 +376,10 @@ module Gates = struct
 end
 
 module Group = struct
-  let scale p (scalar_bits : Boolean.var array) =
-    Pickles.Step_main_inputs.Ops.scale_fast_msb_bits p
-      (Shifted_value scalar_bits)
+  let scale_fast_unpack (base : Field.t * Field.t)
+      (scalar : Field.t Pickles_types.Shifted_value.Type1.t) num_bits :
+      (Field.t * Field.t) * Boolean.var array =
+    Pickles.Step_main_inputs.Ops.scale_fast_unpack base scalar ~num_bits
 end
 
 module Circuit = struct
@@ -575,7 +576,7 @@ let snarky =
 
     val group =
       object%js
-        method scale = Group.scale
+        val scaleFastUnpack = Group.scale_fast_unpack
       end
 
     val circuit =

diff --git a/ocaml/lib/snarky_bindings.mli b/ocaml/lib/snarky_bindings.mli
@@ -221,11 +221,12 @@ val snarky :
       Js.t
       Js.readonly_prop
   ; group :
-      < scale :
-          (   field Snarky_backendless.Cvar.t Tuple_lib.Double.t
-           -> Boolean.var array
-           -> Pickles.Step_main_inputs.Inner_curve.t )
-          Js.meth >
+      < scaleFastUnpack :
+          (   Field.t * Field.t
+           -> Field.t Pickles_types.Shifted_value.Type1.t
+           -> int
+           -> (Field.t * Field.t) * Boolean.var array )
+          Js.readonly_prop >
       Js.t
       Js.readonly_prop
   ; poseidon :