Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds executable file permissions to the cli index #106

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

delambo
Copy link
Member

@delambo delambo commented Sep 8, 2016

for running kyt as a linked npm module

@tizmagik
Copy link
Contributor

tizmagik commented Sep 8, 2016

How was this working before?

@delambo
Copy link
Member Author

delambo commented Sep 8, 2016

We used to link to commands.js but recently added the index.js in front of that to detect Node support. After we switched, I couldn't use npm link anymore to run kyt against other projects locally. When I unlinked and linked again, npm updated the permissions and of course git marked it as a file change.

I'm not sure what the best practice is around permissions, linking and committing. The commands.js file has relaxed permissions for executing (most likely because one of us pushed it up), so I thought I'd push it this up too.

@tizmagik
Copy link
Contributor

tizmagik commented Sep 8, 2016

Makes sense. This seemed to fix it for me, too. So this LGTM 👍

@tizmagik tizmagik merged commit 362f7cb into master Sep 8, 2016
@tizmagik tizmagik deleted the update-file-permissions-oncli branch September 8, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants