-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Numbers field, various improvements #8
Open
timkelty
wants to merge
10
commits into
nystudio107:develop
Choose a base branch
from
timkelty:extend-numbers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid duplicating defaults by simply setting default props. No need to do this AND use a default validator.
This was we don't have to replicate the min/max/defaultValue/decimals/size handling, and we can leverage the parent's normaliztion.
So... do you need me to review this or... do you just wanna merge it yourself? |
Heeey, any reason this is not merged? |
Waiting on @timkelty |
Same here. |
@nitech FWIW, I am using this on a production site… I didn't have time to properly review it, which is why it remains unmerged. |
I understand. From what I see in the comments, @khalwat says he approves the code..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, #3
Summary of changes:
craft\fields\Number
, which removes a lot of duplicate code, allowsdefaultValue
to benull
, and gives us prefix/suffix.Number
:defaultValue
=null
size
=null
decimals
=0
forms.textField
'sunit
option