-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max network number to 8000 instead of 8192 #803
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 89 89
Lines 3809 3812 +3
=======================================
+ Hits 3614 3617 +3
Misses 195 195 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MeshDB can support it, why not update docs/configgen/etc and take advantage of the extra NNs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were all these higher than 8192 in the first place? Were we not enforcing them before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The PR is too old and I don't remember lol
Talked about this in slack. Things will get kind of messy, and it's not worth trying to get an extra 192 addresses in this PR.
|
The docs and configen say the max number is
8000
and we should be consistent with thatAlso enforces minimum and maximum NN at node creation time