Mitigate problem with deeper nested level tests

nvim-neotest · Feb 24, 2024 · 829faeb · 829faeb
1 parent 627a1cc
commit 829faeb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lua/neotest-go/init.lua b/lua/neotest-go/init.lua
@@ -234,8 +234,8 @@ function adapter.prepare_results(tree, lines, go_root, go_module)
       }
       file_id = value.id
     else
-      -- to remove quotes, for example three_level_nested_test.go::TestOdd::"odd"::5_is_odd
-      local value_id = value.id:gsub('%"', "")
+	  -- mitigates `value.id` such as jsonoutput_test.go::Test_Level_1::"Level 2"::Level_3'
+      local value_id = value.id:gsub('%"', ""):gsub(" ", "_")
       local normalized_id = utils.normalize_id(value_id, go_root, go_module)
       local test_result = tests[normalized_id]
       -- file level node

diff --git a/lua/spec/neotest-go/init_spec.lua b/lua/spec/neotest-go/init_spec.lua
@@ -313,6 +313,7 @@ describe("prepare_results", function()
       test_file .. "::TestOdd::odd",
       test_file .. '::TestOdd::"odd"::7_is_odd',
       test_file .. '::TestOdd::"odd"::5_is_odd',
+      test_file .. '::TestOdd::"odd"::"5 is odd"::9_is_odd',
     }
     -- we should run test from module root
     local command = {

diff --git a/neotest_go/three_level_nested_test.go b/neotest_go/three_level_nested_test.go
@@ -8,6 +8,11 @@ func TestOdd(t *testing.T) {
 			if 5%2 != 1 {
 				t.Error("5 is actually odd")
 			}
+			t.Run("9 is odd", func(t *testing.T) {
+				if 9%2 != 1 {
+					t.Error("5 is actually odd")
+				}
+			})
 		})
 		t.Run("7 is odd", func(t *testing.T) {
 			if 7%2 != 1 {