fix: don't show "Updated rock" notification on failed update

nvim-neorocks · Jan 24, 2024 · ee640cd · ee640cd
1 parent 91901b5
commit ee640cd
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/lua/rocks/operations.lua b/lua/rocks/operations.lua
@@ -485,25 +485,26 @@ operations.update = function()
             local success, ret = pcall(future.wait)
             ct = ct + 1
             nio.scheduler()
-            if not success then
-                report_error(("Failed to update %s."):format(rock.name))
+            if success then
+                ---@type rock_name
+                local rock_name = ret.name
+                local user_rock = user_rocks.plugins[rock_name]
+                if user_rock and user_rock.version then
+                    -- Rock is configured as a table -> Update version.
+                    user_rocks.plugins[rock_name].version = ret.version
+                else
+                    user_rocks.plugins[rock_name] = ret.version
+                end
                 progress_handle:report({
+                    message = ("Updated %s: %s -> %s"):format(rock.name, rock.version, rock.target_version),
                     percentage = get_percentage(ct, #outdated_rocks),
                 })
-            end
-            ---@type rock_name
-            local rock_name = ret.name
-            local user_rock = user_rocks.plugins[rock_name]
-            if user_rock and user_rock.version then
-                -- Rock is configured as a table -> Update version.
-                user_rocks.plugins[rock_name].version = ret.version
             else
-                user_rocks.plugins[rock_name] = ret.version
+                report_error(("Failed to update %s."):format(rock.name))
+                progress_handle:report({
+                    percentage = get_percentage(ct, #outdated_rocks),
+                })
             end
-            progress_handle:report({
-                message = ("Updated %s: %s -> %s"):format(rock.name, rock.version, rock.target_version),
-                percentage = get_percentage(ct, #outdated_rocks),
-            })
         end
 
         if vim.tbl_isempty(outdated_rocks) then