perf: load tokyonight.nvim in the intended way #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
reviewed
Feb 17, 2025
| -- Load the colorscheme here. | ||
| -- Like many other themes, this one has different styles, and you could load | ||
| -- any other, such as 'tokyonight-storm', 'tokyonight-moon', or 'tokyonight-day'. | ||
| vim.cmd.colorscheme 'tokyonight-night' | ||
|
|
||
| -- You can configure highlights by doing something like: | ||
| vim.cmd.hi 'Comment gui=none' |
There was a problem hiding this comment.
I'm unsure what it stood for, but why do you remove this?
There was a problem hiding this comment.
This prevented comments from being displayed in italics, as that's the default behavior in Tokyonight. I removed that line of code and instead used Tokyonight's built-in method (as shown in the setup function above).
feoh
approved these changes
Feb 18, 2025
petalas
pushed a commit
to petalas/nvim
that referenced
this pull request
Feb 19, 2025
petalas
pushed a commit
to petalas/nvim
that referenced
this pull request
Feb 19, 2025
Alessandro201
pushed a commit
to Alessandro201/kickstart.nvim
that referenced
this pull request
Feb 19, 2025
charamzic
pushed a commit
to charamzic/kickstart.nvim
that referenced
this pull request
Feb 19, 2025
perf: load tokyonight.nvim in the intended way (nvim-lua#1360) Fixes nvim-lua#1357
SanteriHetekivi
pushed a commit
to SanteriHetekivi/nvim
that referenced
this pull request
Feb 20, 2025
SanteriHetekivi
pushed a commit
to SanteriHetekivi/nvim
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause
tokyonight.nvimto use its cache and set only the necessary highlighting groups according to the installed plugins, and may improve startup time.Fixes #1357.