Update Steam.lua #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified functions to better pull data from Steams updated file system
i077
reviewed
Oct 11, 2021
|
|
||
| --if vdf file exists | ||
| if libVDFFile then | ||
|
|
||
| --iterate through all the lines | ||
| for line in libVDFFile:lines() do | ||
| local dirline = string.match(line,'^%s*"%d+"%s*"(.*)"') --match format for only lines with directories | ||
| local dirline = string.match(line,'%u%:\\\\%a+%d?') --match format for only lines with directories |
There was a problem hiding this comment.
This doesn't seem to match paths more than 1 directory deep (e.g. D:\Games\Steam). Instead, I'd suggest:
Suggested change
| local dirline = string.match(line,'%u%:\\\\%a+%d?') --match format for only lines with directories | |
| local dirline = string.match(line,'"(%u:.*\\.+)"') --match format for only lines with directories |
This way, we greedily match from the drive letter to the last backslash, then include the last segment of the path (since that isn't terminated with a backslash).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified functions to better pull data from Steams updated file system
Due to changes caused by Steams new download management system, Gamedrawer was no longer able to pull data for libraries
on other drives.
Modifications were made to main functions to properly collect needed information to allow application to function.
A function was also needed to filter duplicates from directory table to compensate for current bug. When steam updates, duplicate directories are occasionally created. While these have no noticeable effects on how Steam operates, if not filtered can create bugs in Gamedrawer.