Skip to content

Commit

Permalink
Switch from CocoaPods to Carthage for development
Browse files Browse the repository at this point in the history
and add Carthage support
  • Loading branch information
Conrad Kramer committed Apr 19, 2016
1 parent c813e5d commit 1a2e923
Show file tree
Hide file tree
Showing 24 changed files with 1,857 additions and 461 deletions.
6 changes: 2 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
Pods
Example/WildeGuess/Pod
*xcuserdata
*.xcworkspace
appledoc
*.gcov
.DS_Store
ObjectiveC.gc*
Carthage/Build
ObjectiveC.gc*
9 changes: 9 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[submodule "Carthage/Checkouts/ocmock"]
path = Carthage/Checkouts/ocmock
url = https://github.com/erikdoe/ocmock.git
[submodule "Carthage/Checkouts/xcconfigs"]
path = Carthage/Checkouts/xcconfigs
url = https://github.com/jspahrsummers/xcconfigs.git
[submodule "Carthage/Checkouts/ios-snapshot-test-case"]
path = Carthage/Checkouts/ios-snapshot-test-case
url = https://github.com/facebook/ios-snapshot-test-case.git
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
language: objective-c
osx_image: xcode7.3

before_install:
- gem install cocoapods -v 0.37.2
- brew update
- brew outdated xctool || brew upgrade xctool

script: ./build.sh ci

Expand Down
18 changes: 18 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,24 @@ outlined on that page and do not file a public issue.
## Coding Style
* 2 spaces for indentation rather than tabs

## Updating Testing Dependencies

If you need a different version of one of the testing dependencies, you will need to first install `carthage`:

```
brew install carthage
```

Then, edit `Cartfile.private` to specify the [version](https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md#user-content-version-requirement) of the dependency you'd like to use.

Finally, run

```
carthage update --use-submodules --platform iOS
```

to update the dependency to that version.

## License
By contributing to ComponentKit, you agree that your contributions will be
licensed under its BSD license.
4 changes: 4 additions & 0 deletions Cartfile.private
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
github "erikdoe/ocmock" ~> 3.3
github "facebook/ios-snapshot-test-case" ~> 2.1
github "jspahrsummers/xcconfigs" ~> 0.9

3 changes: 3 additions & 0 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
github "facebook/ios-snapshot-test-case" "2.1.0"
github "erikdoe/ocmock" "v3.3"
github "jspahrsummers/xcconfigs" "0.9"
1 change: 1 addition & 0 deletions Carthage/Checkouts/ios-snapshot-test-case
Submodule ios-snapshot-test-case added at 8e2aca
1 change: 1 addition & 0 deletions Carthage/Checkouts/ocmock
Submodule ocmock added at 0caf33
1 change: 1 addition & 0 deletions Carthage/Checkouts/xcconfigs
Submodule xcconfigs added at d78854
1,804 changes: 1,589 additions & 215 deletions ComponentKit.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

102 changes: 22 additions & 80 deletions ComponentKit.xcodeproj/xcshareddata/xcschemes/ComponentKit.xcscheme
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0700"
LastUpgradeVersion = "0730"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand All @@ -14,68 +14,12 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B3EECEC11AC2366600BFC5DA"
BuildableName = "ComponentKit.app"
BlueprintIdentifier = "D0B47AB41CBD924100BB33CE"
BuildableName = "ComponentKit.framework"
BlueprintName = "ComponentKit"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "A27380191AFD144100E6F222"
BuildableName = "libComponentKitTestHelpers.a"
BlueprintName = "ComponentKitTestHelpers"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DC3F1AC23E8200ACAC53"
BuildableName = "ComponentKitTests.xctest"
BlueprintName = "ComponentKitTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DCA91AC23F2A00ACAC53"
BuildableName = "ComponentTextKitApplicationTests.xctest"
BlueprintName = "ComponentTextKitApplicationTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DC8A1AC23EC300ACAC53"
BuildableName = "ComponentKitApplicationTests.xctest"
BlueprintName = "ComponentKitApplicationTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
Expand All @@ -88,38 +32,38 @@
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DC3F1AC23E8200ACAC53"
BuildableName = "ComponentKitTests.xctest"
BlueprintName = "ComponentKitTests"
BlueprintIdentifier = "B342DC8A1AC23EC300ACAC53"
BuildableName = "ComponentKitApplicationTests.xctest"
BlueprintName = "ComponentKitApplicationTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</TestableReference>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DCA91AC23F2A00ACAC53"
BuildableName = "ComponentTextKitApplicationTests.xctest"
BlueprintName = "ComponentTextKitApplicationTests"
BlueprintIdentifier = "B342DC3F1AC23E8200ACAC53"
BuildableName = "ComponentKitTests.xctest"
BlueprintName = "ComponentKitTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</TestableReference>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B342DC8A1AC23EC300ACAC53"
BuildableName = "ComponentKitApplicationTests.xctest"
BlueprintName = "ComponentKitApplicationTests"
BlueprintIdentifier = "B342DCA91AC23F2A00ACAC53"
BuildableName = "ComponentTextKitApplicationTests.xctest"
BlueprintName = "ComponentTextKitApplicationTests"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B3EECEC11AC2366600BFC5DA"
BuildableName = "ComponentKit.app"
BlueprintIdentifier = "D0B47AB41CBD924100BB33CE"
BuildableName = "ComponentKit.framework"
BlueprintName = "ComponentKit"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
Expand All @@ -137,16 +81,15 @@
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B3EECEC11AC2366600BFC5DA"
BuildableName = "ComponentKit.app"
BlueprintIdentifier = "D0B47AB41CBD924100BB33CE"
BuildableName = "ComponentKit.framework"
BlueprintName = "ComponentKit"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
Expand All @@ -156,16 +99,15 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "B3EECEC11AC2366600BFC5DA"
BuildableName = "ComponentKit.app"
BlueprintIdentifier = "D0B47AB41CBD924100BB33CE"
BuildableName = "ComponentKit.framework"
BlueprintName = "ComponentKit"
ReferencedContainer = "container:ComponentKit.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
21 changes: 21 additions & 0 deletions ComponentKit/ComponentKit.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
//
// Copyright (c) 2014-present, Facebook, Inc.
// All rights reserved.
//
// This source code is licensed under the BSD-style license found in the
// LICENSE file in the root directory of this source tree. An additional grant
// of patent rights can be found in the PATENTS file in the same directory.
//

#include "../Carthage/Checkouts/xcconfigs/iOS/iOS-Framework.xcconfig"

PRODUCT_NAME = ComponentKit
INFOPLIST_FILE = ComponentKit/Info.plist
PRODUCT_BUNDLE_IDENTIFIER = org.componentkit.ComponentKit
ALWAYS_SEARCH_USER_PATHS = NO
CLANG_ENABLE_OBJC_ARC = YES
CLANG_ENABLE_MODULES = YES

ONLY_ACTIVE_ARCH[config=Debug] = YES
GCC_OPTIMIZATION_LEVEL[config=Debug] = 0
COPY_PHASE_STRIP[config=Debug] = NO
4 changes: 2 additions & 2 deletions ComponentKit/Debug/CKComponentDebugController.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
/**
Setting the debug mode enables the injection of debug configuration into the component.
*/
+ (void)setDebugMode:(BOOL)debugMode;
+ (void)setDebugMode:(BOOL)debugMode NS_EXTENSION_UNAVAILABLE("Recursively reflows components using -[UIApplication keyWindow]");

/**
Components are an immutable construct. Whenever we make changes to the parameters on which the components depended,
Expand All @@ -36,7 +36,7 @@
This is particularly used in reflowing the component hierarchy when we set the debug mode.
*/
+ (void)reflowComponents;
+ (void)reflowComponents NS_EXTENSION_UNAVAILABLE("Recursively reflows components using -[UIApplication keyWindow]");

@end

Expand Down
26 changes: 26 additions & 0 deletions ComponentKit/Info.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
<key>NSPrincipalClass</key>
<string></string>
</dict>
</plist>
11 changes: 0 additions & 11 deletions ComponentKitTestLib/ComponentKitTestLib.podspec

This file was deleted.

13 changes: 0 additions & 13 deletions ComponentSnapshotTestCase/ComponentSnapshotTestCase.podspec

This file was deleted.

3 changes: 0 additions & 3 deletions Examples/WildeGuess/Podfile

This file was deleted.

14 changes: 0 additions & 14 deletions Examples/WildeGuess/Podfile.lock

This file was deleted.

Loading

0 comments on commit 1a2e923

Please sign in to comment.