Skip to content

Commit

Permalink
chore: remove test workflow from actions (verdaccio#1323)
Browse files Browse the repository at this point in the history
* chore: remove test workflow from actions

It fails randomly, we need to investigate the reasons.

* chore: re-enable unit test
  • Loading branch information
juanpicado authored May 25, 2019
1 parent 1f42c52 commit 46eeb7e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 22 deletions.
21 changes: 1 addition & 20 deletions .github/main.workflow
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ workflow "release" {
resolves = [
"github-release",
"release:lint",
"release:build",
]
on = "push"
}
Expand Down Expand Up @@ -78,14 +79,6 @@ action "github-release" {
]
}

workflow "build and test" {
resolves = [
"lint",
"coverage",
]
on = "push"
}

action "branch-filter" {
uses = "actions/bin/filter@master"
args = "branch"
Expand All @@ -108,15 +101,3 @@ action "lint" {
needs = ["install"]
args = "yarn run lint"
}

action "test" {
uses = "docker://node:10"
needs = ["build"]
args = "sh scripts/puppeteer-setup-ci.sh"
}

action "coverage" {
uses = "docker://node:10"
needs = ["test"]
args = "yarn run coverage:publish"
}
3 changes: 1 addition & 2 deletions test/unit/api/basic_system.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ describe('basic system test', () => {
server.close(done);
});

// FIXME: we need to investigate why this fails randomly on GitHub Actions
test.skip('server should respond on /', done => {
test('server should respond on /', done => {
request({
url: 'http://localhost:' + port + '/',
}, function(err, res, body) {
Expand Down

0 comments on commit 46eeb7e

Please sign in to comment.