Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cells from misaligning when titles are displayed #746

Merged
merged 2 commits into from
Jan 16, 2018

Conversation

shanwpf
Copy link
Contributor

@shanwpf shanwpf commented Jan 16, 2018

Solves issue #738, doesn't solve #519 though

@mods-bot
Copy link

mods-bot commented Jan 16, 2018

Deploy preview for nusmods ready!

Built with commit 3c72237

https://deploy-preview-746--nusmods.netlify.com

@shanwpf shanwpf closed this Jan 16, 2018
@shanwpf shanwpf reopened this Jan 16, 2018
@shanwpf shanwpf closed this Jan 16, 2018
@shanwpf shanwpf reopened this Jan 16, 2018
@shanwpf shanwpf changed the base branch from master to fix-modulebank-rehydration January 16, 2018 10:50
@shanwpf shanwpf changed the base branch from fix-modulebank-rehydration to master January 16, 2018 10:50
@ZhangYiJiang
Copy link
Member

Hi, the commit history looks kinda wonky. Would you mind fixing that, maybe by resetting to master then recreating the change since it's just one line?

@shanwpf shanwpf reopened this Jan 16, 2018
Copy link
Member

@ZhangYiJiang ZhangYiJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified working on desktop Firefox, Chrome and Safari Mobile. 👍

@ZhangYiJiang ZhangYiJiang merged commit 7b190d9 into nusmodifications:master Jan 16, 2018
@ZhangYiJiang
Copy link
Member

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants