Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous and unnecessary subprocess call #9

Closed
wants to merge 2 commits into from
Closed

Remove erroneous and unnecessary subprocess call #9

wants to merge 2 commits into from

Conversation

nielstron
Copy link
Contributor

At the end of downloading exams, "open -R last-file" is called.
This command is not supported on all operating systems and may be removed in my opinion.

@taneliang taneliang requested a review from yangshun November 15, 2019 04:22
@yangshun
Copy link
Member

yangshun commented Nov 15, 2019

I have no recollection of this (was written 5 years ago) and I can't test it already. @taneliang would you be able to test?

@nielstron
Copy link
Contributor Author

I guess it is a command that works on Windows/Mac but certainly not on all Linux distros.

@taneliang
Copy link
Member

Superseded by #12

@taneliang taneliang closed this Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants