fix "from env" newline handling #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder how this will work on Windows since Windows uses |
|
hmm. that is good question. Here is what I find from other env loader: |
Many .env loaders replace `\n`, `\r`, `\t`. Follow the standard of properly replacing with their literal equivalents when loading the variable for use.
xav-ie
force-pushed
the
fixFromEnvNewLine
branch
from
d22181f to
a7968ad
Compare
|
I updated the PR. I am happy to amend the right hand of the replacement to use |
|
I'm not sure how this'll work but let's try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many (at least the ones I have encountered) env loaders replace "\n" with a
literal newline character when loading an env variable. I need this change in
my personal config and I think others would also prefer this default.