[Ma Jiajun] iP #197
Open
[Ma Jiajun] iP #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,40 @@ | |||
| public class TaskFactory { | |||
There was a problem hiding this comment.
Avoid long methods. Take corrective action when the method exceeds 30 lines of code.
src/main/java/CommandParser.java
Outdated
| throw new HandleException("The input cannot be empty!"); | ||
| } else if (userInput.equalsIgnoreCase("list")) { | ||
| taskList.listTasks(); | ||
| } else if (!userInput.startsWith("todo") && !userInput.startsWith("deadline") && !userInput.startsWith("event")) { |
There was a problem hiding this comment.
This is a fairly complex statement. You might want to break this into sub-expressions and store values into some boolean variables to check for the "if" condition.
src/main/java/TaskList.java
Outdated
| } | ||
|
|
||
| public void addTask(String userInput) throws HandleException { | ||
| // Similar to addTask method in TaskManager, but refactored for this class |
There was a problem hiding this comment.
Make sure the comments are for the reader and not private notes for yourself. It should help in increasing code readability.
| String type = parts[0]; | ||
| Task task = null; | ||
|
|
||
| if (parts.length < 2 || parts[1].isEmpty()) { |
There was a problem hiding this comment.
Avoid the use of Magic numbers.
checked coding standard and quality
checked coding standard and quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.