[YoengKokLeong] iP #176

YoengKokLeong · 2024-02-06T16:29:04Z

Week 4

…for mark and unmark task.

Heart-of-N1 · 2024-02-07T05:37:03Z

src/main/java/Duke.java

-    public static void main(String[] args) {
-        String logo = " ____        _        \n"
+    public static void addList(String line) {
+        System.out.println("--------------------------------------");


I feel like using a constant name variable is better in this case so that the entire presentation feels cleaner without all the dashes. Such as using static String BREAK_LINE = "________________________________________________".

Heart-of-N1 · 2024-02-07T05:40:22Z

src/main/java/Duke.java

Good job on all the naming conventions! :)

Heart-of-N1 · 2024-02-07T05:46:09Z

src/main/java/Duke.java

+
+        introStart(); //Prints starting screen
+
+        boolean ifExit = false; //exits program if true


I think you can consider renaming the boolean variable since the word "ifExit" might not sound like a boolean variable name.

Heart-of-N1 · 2024-02-07T05:47:18Z

src/main/java/Duke.java

+        while (!ifExit) {
+            String line = in.nextLine();
+            if (line.equals("bye")) {
+                //checks for bye interaction and sets ifExit to true


Good job for writing comments for easier understanding of your codes! :)

Haotian199 · 2024-02-07T05:46:27Z

src/main/java/Duke.java

+
+        introStart(); //Prints starting screen
+
+        boolean ifExit = false; //exits program if true


does not sound like a boolean variable

Haotian199 · 2024-02-07T05:48:48Z

src/main/java/Duke.java

@@ -1,10 +1,85 @@
+import java.util.Scanner;
+import java.util.Arrays;
+


overall good naming. names are self explanatory

Haotian199 · 2024-02-07T05:49:56Z

src/main/java/Duke.java

+    }
+
+    public static void main(String[] args) {
+


the code here is very long. could use some commenting to make code easier to read.

Haotian199 · 2024-02-07T05:52:51Z

src/main/java/Duke.java

+
+        while (!ifExit) {
+            String line = in.nextLine();
+            if (line.equals("bye")) {


conditional statements are clear. not a lot of nested if-else statements

Haotian199 · 2024-02-07T05:54:38Z

src/main/java/Duke.java

@@ -1,10 +1,85 @@
+import java.util.Scanner;
+import java.util.Arrays;
+
 public class Duke {


indentations LGTM

…ch. Added documentation as well

Musfirahe0556596

Looks oki! Just some minor coding standard violation

Musfirahe0556596 · 2024-02-23T09:29:04Z

src/main/java/Duke.java

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
+    static boolean ifExit = false; //exits program if true
+    static Task[] tasks = new Task[100]; //List of tasks


just a suggestion: the value 100 can be placed as a named constant so that it's easier for you to change this value (e.g. dh to keep scrolling down the code)

Musfirahe0556596 · 2024-02-23T09:32:33Z

src/main/java/Duke.java

+            echoTask();
+            break;
+        case "event": //add a new event task
+            tasks[listIndex] = new Event(line.substring(0, eventDividerPositionFrom).trim(), line.substring(eventDividerPositionFrom + 5,eventDividerPositionTo).trim(), line.substring(eventDividerPositionTo + 3).trim());


Line length should be no longer than 120 chars

Musfirahe0556596 · 2024-02-23T09:33:01Z

src/main/java/Duke.java

+            echoTask();
+            break;
+        case "deadline": //add a new deadline task
+            tasks[listIndex] = new Deadline(line.substring(0, deadlineDividerPositionBy).trim(), line.substring(deadlineDividerPositionBy + 3).trim());


Line length should be no longer than 120 chars

Musfirahe0556596 · 2024-02-23T09:34:37Z

src/main/java/Duke.java

+        {
+            int printCounter = 1;
+            if (listIndex == 0) {
+                throw new IllegalShapeException(); //Throws exception for empty list
+            }
+            System.out.println("--------------------------------------");
+            System.out.println("Here are the tasks in your lists:");
+            for (Task item : Arrays.copyOf(tasks, listIndex)) {
+                System.out.print(printCounter + ".");
+                System.out.println(item);
+                printCounter++;
+            }
+            System.out.println("--------------------------------------");
+        }


are these extra brackets? (line 25 and 38)

Added "find" feature

added JavaDoc for classes

YoengKokLeong added 4 commits February 2, 2024 04:05

added level 0, 1, 2

95ee6ed

added level 3, added Task class

6e3daab

resolved "bye" bug from adding as Task after exiting. Added dialogue …

dc870cc

…for mark and unmark task.

Followed coding standards

e5227ef

Heart-of-N1 reviewed Feb 7, 2024

View reviewed changes

Haotian199 reviewed Feb 7, 2024

View reviewed changes

YoengKokLeong added 10 commits February 9, 2024 17:00

added child classes Todo, Event and Deadline which Task is parent

4b64426

improved code quality by reducing if else nesting and usage with swit…

896103c

…ch. Added documentation as well

updated text ui testing files

fb46360

updated intro logo

a0adcd9

added exception cases for marking out of bounds and empty listing

45e5691

added exception cases for unmarking out of bounds

2d97f5e

added exception cases for empty inputs

08f21d8

added exception cases for unknown input

6a5db2a

added exception cases for unknown input

df562b0

Added delete feature on new branch

cb99ba4

Musfirahe0556596 reviewed Feb 23, 2024

View reviewed changes

YoengKokLeong and others added 13 commits February 23, 2024 18:08

Added changes

70d9e8a

Merged branch-Level-6

eedfb8b

Added write to file feature

4f643ca

Merged branch-Level-7

ac7095e

Changed task array into a collection with ArrayList

a70f568

Added changes to Level-7

dce7b55

Extracted some classes

d5b0de6

Added "find" feature

a916767

Merge pull request #1 from YoengKokLeong/branch-Level-9

9d267d6

Added "find" feature

added JavaDoc for classes

8de789b

added JavaDoc for classes

809c40e

Merge pull request #2 from YoengKokLeong/branch-A-JavaDoc

c3f232a

added JavaDoc for classes

added user guide

3cc4868

YoengKokLeong added 10 commits March 7, 2024 00:43

added user guide

40ffc50

added user guide

09179f5

added user guide

40526ce

added user guide

3617261

Removed files

a135140

edited changes

d982c9b

fixed bug with marking tasks

7b7992d

fixed bug with saving tasks

f6ecd9e

fixed bug with saving tasks

335e13a

fixed bug with saving tasks

4810915

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[YoengKokLeong] iP #176

[YoengKokLeong] iP #176

YoengKokLeong commented Feb 6, 2024

Heart-of-N1 Feb 7, 2024

Heart-of-N1 Feb 7, 2024

Heart-of-N1 Feb 7, 2024

Heart-of-N1 Feb 7, 2024

Haotian199 Feb 7, 2024

Haotian199 Feb 7, 2024

Haotian199 Feb 7, 2024

Haotian199 Feb 7, 2024

Haotian199 Feb 7, 2024

Musfirahe0556596 left a comment

Musfirahe0556596 Feb 23, 2024

Musfirahe0556596 Feb 23, 2024

Musfirahe0556596 Feb 23, 2024

Musfirahe0556596 Feb 23, 2024


		introStart(); //Prints starting screen

		boolean ifExit = false; //exits program if true

		@@ -1,10 +1,85 @@
		import java.util.Scanner;
		import java.util.Arrays;

[YoengKokLeong] iP #176

Are you sure you want to change the base?

[YoengKokLeong] iP #176

Conversation

YoengKokLeong commented Feb 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Musfirahe0556596 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment