[Yeon Jeho] iP #71

ICubE- · 2023-09-05T05:05:37Z

No description provided.

BenedictChannn

Remember to look through and refactor your code

src/main/java/Nuke.java

src/main/java/Task.java

src/main/java/Nuke.java

text-ui-test/EXPECTED.TXT

Jonoans

Your code is quite well organised, though I think there are some minor things you might have missed for coding standard violations!

src/main/java/Nuke.java

src/main/java/Todo.java

src/main/java/Nuke.java

Add command classes Add exceptions Handle user input exceptions

Fix error in unmark command

exetr

Great work on your iP so far! I have left some comments for your consideration in improving the code quality. Do remember to keep an eye out for usage of magic literals.

src/main/java/nuke/Nuke.java

src/main/java/nuke/command/CommandDeadline.java

src/main/java/nuke/command/CommandParser.java

src/main/java/nuke/savefile/SaveManager.java

SaveFile -> Storage CommandXXX -> XXXCommand

Reduce static parts from Nuke, Storage, Ui

Reduce magic literals

Add find command

NukeDataTime supports both String and LocalDateTime for time variants

Branch level 8

Branch level 9

Branch a javadoc

ICubE- added 12 commits August 19, 2023 15:38

Complete Level-0

94a4a19

Rename class file & Customize answers

bb8421b

Complete Level-1

df853c8

Complete Level-2

26a3cd9

Complete Level-3

b40af3a

Refactor for clean code

8f23d37

Add toString() in Task

68e19ab

Update markTask() and unmarkTask()

7934bea

Complete Level-4

dda2a87

Customize logo and minor stuffs

3cd7157

Automate text ui testing (semi)

ab7c348

Refactor to improve code quality

7a931ef

BenedictChannn reviewed Sep 6, 2023

View reviewed changes

J0shuaLeong reviewed Sep 6, 2023

View reviewed changes

text-ui-test/EXPECTED.TXT Outdated Show resolved Hide resolved

Jonoans reviewed Sep 6, 2023

View reviewed changes

src/main/java/Nuke.java Outdated Show resolved Hide resolved

ICubE- added 14 commits September 6, 2023 13:50

Apply peers' PR comments

75f4047

Fix parsing regex

5f887e2

Complete Level-5

a613e5a

Add command classes Add exceptions Handle user input exceptions

Provide input error details

1b7e33d

Fix error in unmark command

Refactor for clean code

e558683

Fix minor error

54e09f3

Update input.txt and EXPECTED.TXT

aa2850f

Merge branch 'branch-Level-5'

d10e983

Organize classes into packages

31bd2ea

Merge branch 'branch-A-Packages'

9da0899

Update runtest.bat to compile without errors

080dfa1

Complete Level-6

53c43d4

Update command type error detail

015b952

Add forbidden characters

c9c11b7

ICubE- added 2 commits September 16, 2023 13:56

Update .gitignore

1e93e13

Update .gitignore

d36601c

exetr reviewed Sep 17, 2023

View reviewed changes

ICubE- added 27 commits September 19, 2023 15:12

Rename classes and packages

c8e2d6d

SaveFile -> Storage CommandXXX -> XXXCommand

Change minor structure

6045b24

Fix crucial storage error

341c18f

Make the code more OOP

ba173fa

Reduce static parts from Nuke, Storage, Ui

Apply TA's PR comments

3e74a3b

Reduce magic literals

Fix command type error detail

7d860b1

Update .gitignore

056fcab

Rename and remove some methods

1651817

Rename some variables

2cdf203

Complete Level-9

ff41ef8

Add find command

Update test case

997db59

Add NukeDateTime

250bf61

NukeDataTime supports both String and LocalDateTime for time variants

Add exception and minor format

0d21b62

Update NukeDateTime.java

39e4000

Add JavaDoc comments

307adb3

Merge pull request #1 from ICubE-/branch-Level-8

fcfe9dc

Branch level 8

Merge branch 'master' into branch-Level-9

1f72675

Merge pull request #2 from ICubE-/branch-Level-9

61e452d

Branch level 9

Merge branch 'master' into branch-A-JavaDoc

a8bf6b9

Merge pull request #3 from ICubE-/branch-A-JavaDoc

5639125

Branch a javadoc

Change access modifiers of some variables

02b71e1

Update JavaDoc

5c4296f

Refactor TaskParser

fa8f273

Update JavaDoc

6e79886

Update README.md

5b2f391

Update README.md

6fef454

Update README.md

dd4fb3d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Yeon Jeho] iP #71

[Yeon Jeho] iP #71

ICubE- commented Sep 5, 2023

BenedictChannn left a comment •

edited

Loading

Jonoans left a comment

exetr left a comment

[Yeon Jeho] iP #71

Are you sure you want to change the base?

[Yeon Jeho] iP #71

Conversation

ICubE- commented Sep 5, 2023

BenedictChannn left a comment • edited Loading

Choose a reason for hiding this comment

Jonoans left a comment

Choose a reason for hiding this comment

exetr left a comment

Choose a reason for hiding this comment

BenedictChannn left a comment •

edited

Loading