Add Assert test

.gitignore

@@ -8,6 +8,7 @@ src/main/resources/docs/
 /out/
 /*.iml
 
+
 # Storage/log files
 /data/
 /config.json

src/main/java/seedu/address/logic/commands/EditCommand.java

@@ -74,7 +74,7 @@ public CommandResult execute(Model model) throws CommandException {
         requireNonNull(model);
         ObservableList<Employee> lastShownList = model.getFilteredEmployeeList();
 
-        if (!EmployeeId.isValidNumber(employeeId.toString())) {
+        if (!EmployeeId.isValidEmployeeId(employeeId.toString())) {
             throw new CommandException(Messages.MESSAGE_INVALID_EMPLOYEE_DISPLAYED_INDEX);
         }
 

src/main/java/seedu/address/logic/parser/ParserUtil.java

@@ -46,7 +46,7 @@ public static Index parseIndex(String oneBasedIndex) throws ParseException {
      */
     public static EmployeeId parseEmployeeId(String employeeId) throws ParseException {
         String trimmedEmployeeId = employeeId.trim();
-        if (!EmployeeId.isValidNumber(trimmedEmployeeId)) {
+        if (!EmployeeId.isValidEmployeeId(trimmedEmployeeId)) {
             throw new ParseException(MESSAGE_INVALID_EMPLOYEE_ID);
         }
         return new EmployeeId(trimmedEmployeeId);

src/main/java/seedu/address/model/employee/EmployeeId.java

@@ -35,17 +35,17 @@ public EmployeeId() {
      */
     public EmployeeId(String id) {
         requireNonNull(id);
-        checkArgument(isValidNumber(id));
+        checkArgument(isValidEmployeeId(id));
         this.value = String.valueOf(Integer.parseInt(id));
     }
 
 
     /**
      * Returns true if a given string is a valid number, and can possibly be an employee ID.
      */
-    public static boolean isValidNumber(String test) {
+    /*public static boolean isValidNumber(String test) {
         return test.matches(VALIDATION_REGEX);
-    }
+    }*/
 
 
     /**

src/test/java/seedu/address/logic/commands/DeleteCommandTest.java

@@ -3,8 +3,7 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure;
-import static seedu.address.testutil.TypicalEmployeeIds.EMPLOYEE_ID_ONE;
-import static seedu.address.testutil.TypicalEmployeeIds.EMPLOYEE_ID_TWO;
+import static seedu.address.testutil.TypicalEmployeeIds.*;
 import static seedu.address.testutil.TypicalEmployees.getTypicalExecutiveProDb;
 
 import org.junit.jupiter.api.Test;
@@ -65,6 +64,7 @@ public void execute_invalidIndexUnfilteredList_throwsCommandException() {
     public void equals() {
         DeleteCommand deleteFirstCommand = new DeleteCommand(EMPLOYEE_ID_ONE);
         DeleteCommand deleteSecondCommand = new DeleteCommand(EMPLOYEE_ID_TWO);
+        DeleteCommand deleteThirdCommand = new DeleteCommand(EMPLOYEE_ID_THREE);
 
         // same object -> returns true
         assertTrue(deleteFirstCommand.equals(deleteFirstCommand));
@@ -81,6 +81,8 @@ public void equals() {
 
         // different employee -> returns false
         assertFalse(deleteFirstCommand.equals(deleteSecondCommand));
+        assertFalse(deleteThirdCommand.equals(deleteSecondCommand));
+
     }
 
     /**

src/test/java/seedu/address/logic/parser/DeleteCommandParserTest.java

@@ -29,4 +29,4 @@ public void parse_validArgs_returnsDeleteCommand() {
     public void parse_invalidArgs_throwsParseException() {
         assertParseFailure(parser, "a", String.format(MESSAGE_INVALID_COMMAND_FORMAT, DeleteCommand.MESSAGE_USAGE));
     }
-}
+}

src/test/java/seedu/address/testutil/TypicalEmployeeIds.java

@@ -9,4 +9,5 @@
 public class TypicalEmployeeIds {
     public static final EmployeeId EMPLOYEE_ID_ONE = new EmployeeId("1");
     public static final EmployeeId EMPLOYEE_ID_TWO = new EmployeeId("2");
+    public static final EmployeeId EMPLOYEE_ID_THREE = new EmployeeId("3");
 }