Merge pull request #181 from NBQian/PED-Case-Sensitive-bugfix

fix ped bug where commands consider names in a case-sensitive manner.
nus-cs2103-AY2223S2 · Apr 6, 2023 · 62f7037 · 62f7037
2 parents 3942443 + b51057b
commit 62f7037
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/main/java/seedu/address/model/ModelManager.java b/src/main/java/seedu/address/model/ModelManager.java
@@ -154,7 +154,7 @@ public boolean equals(Object obj) {
     public boolean hasDuplicateName(String name) {
         int count = 0;
         for (Student s : filteredPersons) {
-            if (s.getName().toString().contains(name)) {
+            if (s.getName().toString().toLowerCase().contains(name.toLowerCase())) {
                 count++;
             }
         }
@@ -165,7 +165,7 @@ public boolean hasDuplicateName(String name) {
     public boolean hasDuplicateNameAdd(String name) {
         int count = 0;
         for (Student s : filteredPersons) {
-            if (s.getName().toString().contains(name)) {
+            if (s.getName().toString().toLowerCase().contains(name.toLowerCase())) {
                 count++;
             }
         }
@@ -176,7 +176,7 @@ public boolean hasDuplicateNameAdd(String name) {
     public boolean hasDuplicateNameEdit(String name, Integer index) {
         int count = 0;
         for (int i = 0; i < filteredPersons.size(); i++) {
-            if (filteredPersons.get(i).getName().toString().contains(name) && i != index) {
+            if (filteredPersons.get(i).getName().toString().toLowerCase().contains(name.toLowerCase()) && i != index) {
                 count++;
             }
         }
@@ -190,7 +190,7 @@ public boolean hasDuplicateNameEdit(String name, Integer index) {
     public boolean hasExtendedName(String name) {
         int count = 0;
         for (Student s : filteredPersons) {
-            if (name.contains(s.getName().toString())) {
+            if (name.toLowerCase().contains(s.getName().toString().toLowerCase())) {
                 count++;
             }
         }
@@ -201,7 +201,7 @@ public boolean hasExtendedName(String name) {
     public boolean hasExtendedNameEdit(String name, Integer index) {
         int count = 0;
         for (int i = 0; i < filteredPersons.size(); i++) {
-            if (name.contains(filteredPersons.get(i).getName().toString()) && i != index) {
+            if (name.toLowerCase().contains(filteredPersons.get(i).getName().toString().toLowerCase()) && i != index) {
                 count++;
             }
         }
@@ -211,7 +211,7 @@ public boolean hasExtendedNameEdit(String name, Integer index) {
     @Override
     public boolean noSuchStudent(String name) {
         for (Student s : filteredPersons) {
-            if (s.getName().toString().contains(name)) {
+            if (s.getName().toString().toLowerCase().contains(name.toLowerCase())) {
                 return false;
             }
         }

diff --git a/src/main/java/seedu/address/model/student/NamePredicate.java b/src/main/java/seedu/address/model/student/NamePredicate.java
@@ -26,7 +26,7 @@ public NamePredicate(List<String> names) {
     @Override
     public boolean test(Student student) {
         for (String name : names) {
-            if (student.getName().toString().contains(name)) {
+            if (student.getName().toString().toLowerCase().contains(name.toLowerCase())) {
                 return true;
             }
         }