Skip to content

Commit

Permalink
Add assertion to prevent null handlers
Browse files Browse the repository at this point in the history
  • Loading branch information
c0j0s committed Apr 8, 2023
1 parent f7bf237 commit 015c670
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/main/java/seedu/address/ui/jobs/AddDeliveryJobWindow.java
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ private void viewRecipientAddressBook() {
* @param handler
*/
public void setResultHandler(Consumer<CommandResult> handler) {
assert handler != null;

this.completeEditCallback = Optional.of(handler);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ public void fillInnerParts(ReadOnlyAddressBook ab) {
* @param handler
*/
public void setEditHandler(Consumer<DeliveryJob> handler) {
assert handler != null;

handleEdit = handler;
}

Expand All @@ -147,6 +149,8 @@ public void setEditHandler(Consumer<DeliveryJob> handler) {
* @param handler
*/
public void setCompleteHandler(Consumer<DeliveryJob> handler) {
assert handler != null;

handleComplete = handler;
}

Expand All @@ -156,6 +160,8 @@ public void setCompleteHandler(Consumer<DeliveryJob> handler) {
* @param handler
*/
public void setDeleteHandler(Consumer<DeliveryJob> handler) {
assert handler != null;

handleDelete = handler;
}

Expand Down
11 changes: 10 additions & 1 deletion src/main/java/seedu/address/ui/jobs/DeliveryJobListPanel.java
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ public int size() {
* @param handler
*/
public void setSelectHandler(BiConsumer<Integer, DeliveryJob> handler) {
assert handler != null;

this.onSelectHandler = Optional.of(handler);
}

Expand All @@ -193,6 +195,8 @@ public void setSelectHandler(BiConsumer<Integer, DeliveryJob> handler) {
* @param handler
*/
public void setCheckHandler(Consumer<DeliveryJob> handler) {
assert handler != null;

this.onCheckHandler = Optional.of(handler);
}

Expand All @@ -202,6 +206,8 @@ public void setCheckHandler(Consumer<DeliveryJob> handler) {
* @param handler
*/
public void setDeleteHandler(Consumer<DeliveryJob> handler) {
assert handler != null;

this.onDeleteHandler = Optional.of(handler);
}

Expand All @@ -211,7 +217,8 @@ public void setDeleteHandler(Consumer<DeliveryJob> handler) {
* @param handler
*/
public void setOrderByHandler(BiFunction<DeliverySortOption, Boolean, ObservableList<DeliveryJob>> handler) {
// orderOption = Optional.of(handler);
assert handler != null;

sortHandler = Optional.of(handler);
orderOption.setVisible(true);
}
Expand All @@ -220,6 +227,8 @@ public void setOrderByHandler(BiFunction<DeliverySortOption, Boolean, Observable
* Sets handler to filter
*/
public void setFilterHandler(Consumer<DeliveryFilterOption> con) {
assert con != null;

filterOption.setVisible(true);
filterDelivered.setToggleGroup(toggleGroup);
filterPending.setToggleGroup(toggleGroup);
Expand Down

0 comments on commit 015c670

Please sign in to comment.