[Ming Liang Ng] Duke Increments #19

Dban1 · 2020-01-24T10:25:10Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

-added error handling for unknown commands -added error handling for wrong number of parameters given for commands -added error handling for "done" if number is not given in parameter [1]

-added "delete" command along with error handling similar to "done"

-Improved checkstyle configuration

…meant for conversion into string for storage -Duke.java now reads/stores from the ./../data/duke.txt file

-created the Parser, Storage, TaskList and Ui class -To-dos (Parser.java)

-other touch ups to get OOP Duke functional

JeremyLoh

Good to see OOP used for your Duke. Consider refactoring out your Command class (e.g. DeleteCommand, parsing functions to be placed in Parser class instead).
Good job! 👍

JeremyLoh · 2020-02-03T05:19:01Z

src/main/java/duke/commands/Command.java

@@ -0,0 +1,162 @@
+package duke.commands;
+
+import duke.tasks.*;


Try to import all classes used, instead of *.
In IntelliJ, the * import can be disabled by going to
Settings -> Editor -> Code Style -> Java, and under the Imports tab, the number of class count before * is used can be increased. (Under Class count to use import with *). I've changed mine to a reasonably higher number (200).

JeremyLoh · 2020-02-03T05:21:33Z

src/main/java/duke/commands/Command.java

+    }
+
+    public void execute(TaskList taskList, Storage storage, Ui ui) throws DukeException {
+        switch (this.commandWord) {


Good use of the switch statement, instead of having if else blocks and using equals()
If you like to refactor this Command class, you could break up the commands into subclasses (e.g. DeleteCommand, ListCommand etc.)

Yes, I think you could place Commands enum in a separate Java file, for better code readability.

JeremyLoh · 2020-02-03T05:22:51Z

src/main/java/duke/commands/Command.java

+            } catch (Exception e) {
+                throw new DukeException("Input a number boi.");
+            }
+            if (Integer.parseInt(this.elements[1]) > taskList.getTaskList().size()) {


Good to see error checking for the done command 👍

JeremyLoh · 2020-02-03T05:24:27Z

src/main/java/duke/commands/Command.java

+            this.isExit = true;
+            break;
+        case "list":
+            if (taskList.getTaskList().size() < 1) {


Maybe the task list and size of the task list could be placed outside of the switch statement as variables, to prevent extra calls to the getTaskList() and size() function

JeremyLoh · 2020-02-03T05:27:29Z

src/main/java/duke/storage/Storage.java

+import java.util.List;
+import java.util.ArrayList;
+
+import duke.tasks.*;


import duke.tasks.* should be replaced with the individual classes in the tasks package.

JeremyLoh · 2020-02-03T05:29:08Z

src/main/java/duke/storage/Storage.java

+    /**
+     * Builds a TaskList class from storage Filepath.
+     * @return Returns a TaskList class built according to storage Filepath. Returns an empty TaskList class
+     * if there is no storage file.
+     * @throws DukeException Filepath not found.
+     */


Based on the coding standards here, there should be an empty line between description and parameter section.

JeremyLoh · 2020-02-03T05:30:37Z

src/main/java/duke/storage/Storage.java

+    }
+
+    /**
+     * Saves given TaskList to the storage file.


Slight formatting problem for JavaDoc: require empty line between parameters and description.

JeremyLoh · 2020-02-03T05:31:19Z

src/main/java/duke/tasks/Deadline.java

+     * Creates a Deadline class.
+     * @param strArr Array of String containing input for the Deadline class.


Needs a blank line between the JavaDoc description and parameter.

JeremyLoh · 2020-02-03T05:33:42Z

src/main/java/duke/ui/Parser.java

+public class Parser {
+    public static Command parseCommand(String input) {
+        return new Command(input);
+    }
+}


Maybe you could place the functions related to parsing user string input here instead of putting it inside the Command class.

JeremyLoh · 2020-02-03T05:34:56Z

src/main/java/duke/ui/Ui.java

+     */
+    public void farewellUser() {
+        divider("Aww, see you again soon!");
+        return;


I think the return; statement here could be removed as this function has a return type of void.

… icons

nathanaelseen

Good OOP design overall, the entities are logically and appropriately modularised.

nathanaelseen · 2020-02-05T12:21:28Z

src/main/java/duke/main/Duke.java

+
+    /**
+     * Constructs a Duke class.
+     * @param filePath Filepath of the storage file tasks.txt


Try to leave an empty line between method description parameter section.

nathanaelseen · 2020-02-05T12:23:10Z

src/main/java/duke/tasks/Event.java

+
+    /**
+     * Creates an Event class.
+     * @param strArr Array of String containing input for the Event class.


Try to leave and empty line between parameter and method descriptions.

nathanaelseen · 2020-02-05T12:24:13Z

src/main/java/duke/ui/Ui.java

+
+    /**
+     * Prints out input String within two divider lines. If input string is empty, prints out single line.
+     * @param s String to be wrapped by two divider lines.


Try to leave an empty line between parameter description and method description.

nathanaelseen · 2020-02-05T12:26:48Z

src/main/java/duke/commands/Command.java

+    }
+
+    public void execute(TaskList taskList, Storage storage, Ui ui) throws DukeException {
+        switch (this.commandWord) {


Yes, I think you could place Commands enum in a separate Java file, for better code readability.

jothipillay · 2020-02-08T18:36:24Z

Try not to use magic numbers in your code! Declare values inside static final variables and use them instead. Other than that everything generally looks great. Keep up the good work! :)

…dity of dates before current date -shortened `divider` method in Ui

-implemented `assert` for Event and Deadline for sanity check on vali…

-removed obsolete code in Duke for old handleUserInput() -tweaked Task `create()` method

-implemented some refactoring in Ui for `System.out.println()` method

-added introductory message to GUI -bug fix for C-Tag

…om Duke)

… export

j-lum and others added 30 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S2#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S2#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

JavaFX tutorial: Support cross-platform JARs

c4678f7

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

JavaFX tutorial: Support cross-platform JARs [nus-cs2103-AY1920S2#16]

30efbae

Merge branch 'master' of https://github.com/Dban1/duke

d357353

-configured Gradle settings according to given tutorial

d28d450

-implemented Level-1

d302ad2

-implemented Level 2

de5cf6a

-implemented Level 3

50c056c

-implemented Level 3

2013802

-implemented Level 5

35dc397

-added error handling for unknown commands -added error handling for wrong number of parameters given for commands -added error handling for "done" if number is not given in parameter [1]

-implemented Level 6

fd55b66

-added "delete" command along with error handling similar to "done"

-Implemented A-TextUiTesting

92e9bc5

-Improved checkstyle configuration

-Deadline, Event, Task, Todo all now have store and create functions …

9be1963

…meant for conversion into string for storage -Duke.java now reads/stores from the ./../data/duke.txt file

-removed debugging text from Duke.java

bd79f2b

-implemented date objects for Deadline and Event types

e8b3c6e

Merge branch 'branch-Level-8'

72c4a82

-implemented Phase 1 untested code refactoring for More-OOP

ec6b2ae

-created the Parser, Storage, TaskList and Ui class -To-dos (Parser.java)

-implemented Phase 1 untested code refactoring for More-OOP

7715f68

-created the Parser, Storage, TaskList and Ui class -To-dos (Parser.java)

-implemented and abstracted Command

48cf552

-other touch ups to get OOP Duke functional

-implemented packaging

f085a08

-removed old java files pre-package

2bbaf0d

-half implementation of JUnit 5 and TodoTest

75cff4d

-implemented JUnit tests for Todo and TaskList

3563c35

-implemented some JavaDoc

dfc9d89

-fixed indentations to comply with RedHat coding standard

bfc719d

JeremyLoh reviewed Feb 3, 2020

View reviewed changes

Dban1 added 6 commits February 3, 2020 16:44

-further semi-implementation of Level-10, up to dialog boxes with the…

4b2ee7e

… icons

-implemented tutorial 3

07de871

-implemented JavaFX part 4

f19cf1b

-updated tasks.txt

e285aa2

-minor edits to Ui

ba437ae

Merge branch 'branch-Level-10'

8e3071c

nus-se-bot mentioned this pull request Feb 4, 2020

Feedback on week 4 project progress for jeremyloh JeremyLoh/duke#3

Open

5 tasks

nathanaelseen reviewed Feb 5, 2020

View reviewed changes

nus-se-bot mentioned this pull request Feb 6, 2020

Feedback on week 4 project progress for nathanaelseen nathanaelseen/duke#3

Open

3 tasks

-implemented assert for Event and Deadline for sanity check on vali…

afb7efc

…dity of dates before current date -shortened `divider` method in Ui

Dban1 force-pushed the master branch from afb7efc to 8e3071c Compare February 12, 2020 16:33

Dban1 and others added 17 commits February 13, 2020 00:36

Merge pull request #4 from Dban1/branch-A-Assertions

6b2a04b

-implemented `assert` for Event and Deadline for sanity check on vali…

-implemented some refactoring in Ui for System.out.println() method

4d59e03

-removed obsolete code in Duke for old handleUserInput() -tweaked Task `create()` method

Merge branch 'master' into branch-A-CodeQuality

d5cb942

Merge pull request #5 from Dban1/branch-A-CodeQuality

54eaae8

-implemented some refactoring in Ui for `System.out.println()` method

-implemented tagging

52fa39a

-fixed GUI checkmarks and crossmarks

a9cc81f

-added introductory message to GUI -bug fix for C-Tag

-reverted font to working font (Arial, 11, caused ellipses replies fr…

11b82b2

…om Duke)

-fixed "bye" command for GUI

f8575f6

-fixed up storage path for Tasks.txt into same folder as Duke.jar for…

e27870b

… export

-included Ui.PNG

e48ab04

-wrote up User Guide

73bf2ff

Set theme jekyll-theme-midnight

5908593

Set theme jekyll-theme-midnight

5226c80

-removed Ui.PNG

b6ab05b

-added Ui.png

a1b21be

Merge branch 'master' of https://github.com/Dban1/duke

761cc5b

-removed checkstyle errors

017e79d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ming Liang Ng] Duke Increments #19

[Ming Liang Ng] Duke Increments #19

Dban1 commented Jan 24, 2020

JeremyLoh left a comment

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

nathanaelseen Feb 5, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

JeremyLoh Feb 3, 2020

nathanaelseen left a comment

nathanaelseen Feb 5, 2020

nathanaelseen Feb 5, 2020

nathanaelseen Feb 5, 2020

nathanaelseen Feb 5, 2020

jothipillay commented Feb 8, 2020

		* Creates a Deadline class.
		* @param strArr Array of String containing input for the Deadline class.

[Ming Liang Ng] Duke Increments #19

Are you sure you want to change the base?

[Ming Liang Ng] Duke Increments #19

Conversation

Dban1 commented Jan 24, 2020

JeremyLoh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nathanaelseen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jothipillay commented Feb 8, 2020