[Lim Ao Jun Joel] Duke Increments #15

joel-lim · 2020-01-24T05:24:08Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.

…requested

… directories if file path is non-existent

…ad of generating a new one for each command

…method

A-Assertions: Use assert feature (not JUnit assertions) to document important assumptions that should hold at various points in the code.

okkhoy

In general, you may want to pay specific attention to SLAP. There are a few instances where some code looks repeated. Those can be extracted to methods.

okkhoy · 2020-02-09T06:17:43Z

src/main/java/duke/Duke.java

+                try {
+                    inputLock.acquire();
+                } catch (InterruptedException e) {
+                    e.printStackTrace();


You have some custom exceptions, why not use it here effectively?
In general, printing stacktrace is not considered good exception handling.

okkhoy · 2020-02-09T06:18:14Z

src/main/java/duke/Duke.java

+        }
+
+        // Save to disk
+        try {


btw, each of this can be extracted out to separate methods to improve the SLAP.

okkhoy · 2020-02-09T06:19:00Z

src/main/java/duke/Main.java

+            e.printStackTrace();
+        }
+    }
+}


You may want to add a new line at the end of the file to keep checkstyle happy 😛

okkhoy · 2020-02-09T06:19:36Z

src/main/java/duke/commands/Command.java

+ */
+public interface Command {
+    /**
+     * Parses the given argument string and executes the Command.


if the method is really doing both parsing and executing the command, you may want to separate out the two functionalities.

okkhoy · 2020-02-09T06:20:58Z

src/main/java/duke/commands/CommandHandler.java

+    private void executeCommand(String commandWord, String arg) {
+        try {
+            commands.get(commandWord).execute(arg, tasks, ui, storage);
+        } catch (NullPointerException e) {


why not handle this NPE earlier before calling the execute command?

okkhoy · 2020-02-09T06:46:07Z

src/main/java/duke/parsers/DateTimeParser.java

+        dtFormatters.add(DateTimeFormatter.ofPattern("dd/MM/yyyy[ HH][:][mm][:ss]"));
+        dtFormatters.add(DateTimeFormatter.ofPattern("dd-MM-yyyy[ HH][:][mm][:ss]"));
+        dtFormatters.add(DateTimeFormatter.ofPattern("dd MM yyyy[ HH][:][mm][:ss]"));


I agree with the above ☝️ 🙂

okkhoy · 2020-02-09T06:48:13Z

src/main/java/duke/storage/TextStorage.java

+            return String.format("deadline\n%s\n%s\n%s", deadline.getName(), deadline.getDateTime(),
+                    deadline.getIsDone());
+        } else {
+            assert task instanceof Event;


okkhoy · 2020-02-09T06:51:51Z

src/main/java/duke/ui/TextUi.java

+    private Scanner sc;
+
+    public TextUi() {
+        lineBreak = "===========================================================\n";


why is lineBreak here? I don't see it being used immediately.

okkhoy · 2020-02-09T06:52:48Z

src/main/java/duke/ui/Ui.java

+package duke.ui;
+
+/**
+ * Allows Duke to display output to the user.


You can give a better description in this header comment

okkhoy · 2020-02-09T06:53:33Z

src/test/java/duke/parsers/DateTimeParserTest.java

+        String invalidDate = "11/13/2000";
+        String validDateWithSlash = "11/12/2000";
+        String validDateWithDash = "11-12-2000";
+        String validDateWithSpace = "11 12 2000";


when you are writing larger tests, consider moving such setup information to separate methods. find out what @before and @after do in Junit.

joel-lim · 2020-02-10T14:08:36Z

Thanks prof for the feedback and suggestions! I will refactor my code to better adhere to SLAP and to reuse code more :-)

…ing)

Amanda1232 · 2020-11-03T15:09:52Z

src/main/java/duke/commands/CreateDeadline.java

+
+        save(storage, tasks);
+
+        ui.showReply(String.format("Got it. I've added this task:\n  %s\nNow you have %d tasks in the list.", newTask,
