[Zhang Yuanyu] Duke Increments #12
Conversation
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.
This reverts commit 254e72b.
Currently merging branch-level-8 with master(which is merged with branch-level-7 previously).
This reverts commit 59bef2e.
… the merging of level 7 and level 8.
Merging Level-7 with master
…d duke.txt to data directory
src/main/java/duke/Duke.java
Outdated
|
|
||
| /** | ||
| * You should have your own function to generate a response to user input. | ||
| * Replace this stub with your completed method. |
There was a problem hiding this comment.
Overall really good abstraction and encapsulation! Only a minor feedback for javadocs, perhaps you could be more consistent with the format of the comments and spacings between methods. Using gradle's checkstyle might help. But overall really clean code!
There was a problem hiding this comment.
Keep up the good job!
There are some minor things that to improve. Please see the individual comments.
PS: you seem to be tracking many unnecessary files in your repo. Check how you can remove them from being tracked and update the git ignore file to prevent them from being tracked. (be careful when you use git rm in the command line)
| fxmlLoader.<MainWindow>getController().setDuke(duke); | ||
| stage.show(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
In general, printing stack trace is not good error handling. Think if there is anything better you can do about the exception rather than printing the stack trace.
| * You should have your own function to generate a response to user input. | ||
| * Replace this stub with your completed method. | ||
| */ | ||
| public String getResponse(String input) { |
There was a problem hiding this comment.
Update header comments to reflect the changes.
| */ | ||
| public abstract class Task { | ||
| protected String description; | ||
| protected boolean isDone; |
There was a problem hiding this comment.
good job on naming the boolean variable correctly
| } | ||
| /** | ||
| * Returns the text to be saved into the storage file. | ||
| * @return The text to be saved to storage file. |
There was a problem hiding this comment.
@return is redundant as the earlier line conveys the same information.
…e provided keyword does not exist in the task list.
Storage: Updated assertions in load() method.
Updated some javadocs do adhere to coding quality.
… with the commands.
…ssages respectively.
Merge with master for updated user guide.
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S2#9)
Pull request for Duke Individual Project levels 1-6.