Minor tweaks within code #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expected.txt: Fixed typo error or "Addess" to "Address"
AddressBook.java: Reformat email inputs to lower case in extractEmailFromPersonString(String encoded) method. input.txt: Updated input test cases to include emails with varying case expected.txt: Updated expected test cases to include the emails with varying case to check if correct (lower) case emails are displayed correctedly
|
@IamRENCE it is enough to push your commits to your own fork. No need to create a PR. |
|
Hello Prof,
Can I check if my account is linked to my NUS NetID e0175937? I did the pre-module survey and I hope to confirm that it is linked.
Thanks!
Cheers,
Terence
Sent from my Samsung Galaxy smartphone.
…-------- Original message --------
From: "Damith C. Rajapakse" <[email protected]>
Date: 29/08/2018 13:30 (GMT+08:00)
To: nus-cs2103-AY1819S1/addressbook-level1 <[email protected]>
Cc: "Goh Yang Yu, Terence" <[email protected]>, Mention <[email protected]>
Subject: Re: [nus-cs2103-AY1819S1/addressbook-level1] Minor tweaks within code (#12)
@IamRENCE<https://github.com/IamRENCE> it is enough to push your commits to your own fork. No need to create a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AldIrhJxVPJy1xNEMe6ZM6WXgpD7B9Flks5uVibbgaJpZM4WQ18e>.
|
|
We are fixing some loopholes in the script. Please ping me again if you didn't receive the correct response for the AB1 enhancement by the end of this week. |
Sorry, I missed this query. Did you get marks for it? |
|
Hello Prof,
Yes, I did after a few days later. Sorry for the inconvenience!
Thanks.
Cheers,
Terence
From: Damith C. Rajapakse<mailto:[email protected]>
Sent: Friday, 7 September 2018 8:44 PM
To: nus-cs2103-AY1819S1/addressbook-level1<mailto:[email protected]>
Cc: Goh Yang Yu, Terence<mailto:[email protected]>; Mention<mailto:[email protected]>
Subject: Re: [nus-cs2103-AY1819S1/addressbook-level1] Minor tweaks within code (#12)
Can I check if my account is linked to my NUS NetID e0175937? I did the pre-module survey and I hope to confirm that it is linked.
Sorry, I missed this query. Did you get marks for it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AldIrpVgJk7DX0ZUxGrX1oVTWjY6UCn_ks5uYmoYgaJpZM4WQ18e>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: