-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.5rc][F12-B4] HuatAh! #75
base: master
Are you sure you want to change the base?
[v1.5rc][F12-B4] HuatAh! #75
Conversation
Hi @jonleeyz, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonleeyz @zhangriqi @der-erlkonig @melvintzw Please change the product name in readme. It should not be AB4 at this point and make the PR before the tutorial. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things: 1. Please update the AboutUs, ContactUs pages asap. 2. You should re-write the whole UG to reflect the changes you intent to make for your own app. (the features should be up to V2.0) Mark them accordingly with the version. 3. More details should be documented in the DG as you go along. You might not have time to do it in one shot later. You should have a product survey for DG as well. Please take note of the above points. 4. You should update the PR title each week. Replace the "X" with correct version number. Due to the incomplete UG, I have to change the team component to 0 for last tutorial as the changes are required. (the lead tutor insisted for all teams to do this) @jonleeyz @melvintzw @der-erlkonig @zhangriqi
docs/DeveloperGuide.adoc
Outdated
|
||
|`*` |user with many persons in the address book |sort persons by name |locate a person easily | ||
|`*` |user |export my current view to another format |view specific information in another format or print out a hardcopy and pass the information to subordinates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update MSS accordingly. I believe you do have new commands which have different workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For DG, it is good that you have included some code snippets, but do not overdo it. Use of UML diagrams is lacking. Please use your UML knowledge to explain your design. It is important to have diagrams in your project portfolio. UG should be in sync with you changes. Google map feature should be also included. Same applies to other new features. You can mark "Since V1.2" to indicate them clearly, similar to the marking "Coming in V2.0". Please mark sure your UG is ready before peer testing. @jonleeyz @melvintzw @der-erlkonig @zhangriqi
…pdateStorageForAddCommand Storage Enhancements for PetPatients
Hey @OuyangDanwen! Would there be a review of this PR for Milestone 1.3? Otherwise, we will rename it soon to v1.4! Thanks! |
…1.4YuxiangSg test collation
Rebrand: LoanShark Manager -> HuatAh!
HtmlWriter Tests, DevGuide
add tag references to FindCommandEnhancement, ModelTwo in PPP
Changes to PPP and DevGuide
Update PPP and documentation
Update: Documentation
Update: Developer Guide
Auto updating Pull Request from our team repo to the course repo.
@melvintzw
@der-erlkonig
@zhangriqi