Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5][F09-B3] CoinBook #62

Open
wants to merge 122 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
cdfa095
Add COMMAND_ALIAS as an attribute to each command.
eldon-chung Mar 8, 2018
946207f
Modify AddressBookParser to recognise Command aliases and modify test…
eldon-chung Mar 8, 2018
898b71a
Update the user guide to mention command aliases
eldon-chung Mar 8, 2018
4d4293d
[#9] Add support for command aliases (#13)
ewaldhew Mar 8, 2018
5608594
Add backupAddressBook method to AddressBookStorage interface
laichengyu Mar 8, 2018
8922b92
Add overloaded backupAddressBook method
laichengyu Mar 8, 2018
d85fbbe
Remove unneeded overloaded method
laichengyu Mar 8, 2018
4078d53
Add backupAddressBook method to StorageManager class
laichengyu Mar 8, 2018
cd403d8
Add backupAddressBook method to XmlAddressBookStorage class
laichengyu Mar 8, 2018
cd24669
Remove trailing whitespaces
laichengyu Mar 8, 2018
2a56b3e
[#12] Add backup API for address book storage (#17)
ewaldhew Mar 9, 2018
b1f1643
[#11] Various UI enhancements (#16)
ewaldhew Mar 9, 2018
ff7335a
v1.0 Documentation (#29)
ewaldhew Mar 14, 2018
bd1f5b8
Update docs images (#32)
ewaldhew Mar 15, 2018
a259c0b
[#23] README.adoc: Add product description (#31)
neilish3re Mar 15, 2018
83ff03a
[#25] Add fetch utility class to obtain data from external APIs (#39)
laichengyu Mar 15, 2018
32b2fc3
[#28] Add news panel (#34)
eldon-chung Mar 15, 2018
674fa0c
[#21] UserGuide: Update user guide to describe the project (#38)
eldon-chung Mar 15, 2018
9faee50
[#22] AboutUs.adoc: Update with own team (#35)
ewaldhew Mar 15, 2018
ae6f59d
[#27] Charts panel component (#33)
ewaldhew Mar 15, 2018
2710200
v1.1: Fix warnings (#42)
ewaldhew Mar 16, 2018
746c28d
Version 1.1 released (#48)
ewaldhew Mar 16, 2018
ca959c7
[#36] Merge browser window (#47)
eldon-chung Mar 16, 2018
52be103
DeveloperGuide.adoc#App.B: Add Feature Contribution (#66)
ewaldhew Mar 19, 2018
2ab8b8f
v1.2 Documentation (#64)
ewaldhew Mar 20, 2018
dab145d
[#41] UsingCheckstyle.adoc: Add crucial step into instructions (#73)
ewaldhew Mar 22, 2018
3d3f6ed
[#40] UserGuide.adoc: Mark features (#76)
eldon-chung Mar 22, 2018
3f643d3
[#40] Add autocomplete to user guide (#75)
laichengyu Mar 22, 2018
9d4b6f2
[#58][#63] Generic URL builder for API calls (#77)
laichengyu Mar 22, 2018
7074714
[#65] v1.2 Documentation: Developer Guide (#67)
ewaldhew Mar 23, 2018
c7db6b8
[#61] Prepare for new feature (#68)
ewaldhew Mar 23, 2018
3725ca3
[#26] Refactor person class (#78)
eldon-chung Mar 23, 2018
6de95fa
Version 1.2 released (#79)
ewaldhew Mar 23, 2018
89ca531
Documentation: Edit for style, Add diagrams (#86)
ewaldhew Mar 25, 2018
929f916
[#26] Change most instances of `Address` to `Coin` (#87)
ewaldhew Mar 28, 2018
266be0d
Relink README, Add UG usage (#100)
ewaldhew Mar 29, 2018
6870d1e
[#46] Add Find command arguments parser (#102)
eldon-chung Mar 29, 2018
730a0da
Change Edit command to Tag command (#98)
ewaldhew Mar 29, 2018
91d7ff7
[#104] BuyCommand: Add new command (#106)
ewaldhew Mar 30, 2018
f26ac68
Version 1.3 released (#107)
ewaldhew Mar 30, 2018
04ef9b9
[#89] Add SyncCommand (#110)
laichengyu Mar 31, 2018
238bb2e
[#111] Merge Lexer.java into ArgumentTokenizer.java (#112)
eldon-chung Mar 31, 2018
83c6a79
Version 1.3b released (#113)
ewaldhew Mar 31, 2018
abec483
Add `buy` command related tests (#108)
ewaldhew Apr 5, 2018
150c34c
[#117] Add multi-word tags (#119)
eldon-chung Apr 5, 2018
d0e5578
[#60] Basic notification add and display window support (#122)
ewaldhew Apr 6, 2018
95c2cf2
v1.4 Documentation (#116)
ewaldhew Apr 6, 2018
ee4675f
[#105] Basic commands (#118)
ewaldhew Apr 6, 2018
0b861c4
Version 1.4 released (#130)
ewaldhew Apr 6, 2018
8857c7e
Fix help messages for commands (#131)
ewaldhew Apr 6, 2018
aa8ee44
Fix broken test (#134)
ewaldhew Apr 6, 2018
45a2d44
Ui.png: Update to v1.4 (#132)
eldon-chung Apr 6, 2018
2dce6a2
[#126] Improve SyncCommand (#133)
laichengyu Apr 6, 2018
6214ed2
Version 1.4 revised (#135)
ewaldhew Apr 6, 2018
5d8dda0
TokenType.java: Refactor prefix token type names. (#141)
eldon-chung Apr 7, 2018
139d497
Coin.java: Refactor get profit, worth and profitability to return Amo…
eldon-chung Apr 7, 2018
b629090
CoinBook: Refactor all instances of Address to Coin (#147)
eldon-chung Apr 7, 2018
4a2ef97
[#46] Add condition generator (#179)
eldon-chung Apr 8, 2018
79cf6dd
[#181] Tag#TAG_VALIDATION_REGEX: Only allow single worded tag names (…
eldon-chung Apr 8, 2018
4714ec0
[#188] Refactor code condition (#189)
eldon-chung Apr 8, 2018
cb61618
[#184] Coin: Revise equals method to only check Code attribute (#185)
eldon-chung Apr 8, 2018
217ace6
[#152] CommandTarget#toIndex: Use getSourceIndex method (#183)
eldon-chung Apr 8, 2018
8edacd8
Fix bugs (#193)
eldon-chung Apr 11, 2018
9b0c9f3
[#194] Add amount condition superclass (#195)
eldon-chung Apr 11, 2018
d74b855
[#57] Add news view (#198)
eldon-chung Apr 12, 2018
154a5f4
[#109] Coin Amounts fixes (#199)
ewaldhew Apr 12, 2018
0144065
ParserUtil: Add warning logging for when Find argument parsing fails …
eldon-chung Apr 12, 2018
b967905
[#88] Notification Center (#201)
ewaldhew Apr 12, 2018
32c7cb0
[#167] Refactor tests - Rename addressbook stuff (#202)
eldon-chung Apr 12, 2018
74a90e2
[#203] Rename address to coin in all commands, parameter names, and s…
eldon-chung Apr 12, 2018
0cc9ad7
Fix targeted commands (#205)
ewaldhew Apr 12, 2018
904c39f
Deal with unused files (#206)
ewaldhew Apr 12, 2018
1906ff7
Refactor sync command (#208)
ewaldhew Apr 12, 2018
302c86d
D2 Documentation (#187)
ewaldhew Apr 12, 2018
20a539f
[#162] Refactor tests part 2 (#211)
eldon-chung Apr 12, 2018
06b2321
[#54] Autocomplete feature (#212)
laichengyu Apr 12, 2018
cdbb185
Update Project Portfolio for neilish3re (#210)
neilish3re Apr 12, 2018
6ca5763
SampleDataUtil: Change Coin names to actual Coin names (#215)
eldon-chung Apr 12, 2018
918aca1
PPP(Eldon-Chung): Add (#213)
eldon-chung Apr 13, 2018
d344041
UserGuide: Add examples (#218)
eldon-chung Apr 13, 2018
ab09b41
[#59] Add generation of coin change events for rule checker (#220)
ewaldhew Apr 13, 2018
d86dc52
SyncCommand: Refactor toString to getAsString during Price constructi…
eldon-chung Apr 13, 2018
25f165e
MainWindow: Make notifications pop-up (#222)
ewaldhew Apr 13, 2018
5fee879
Add Portfolio Page (ewaldhew) (#190)
ewaldhew Apr 13, 2018
9d360f2
PPP(laichengyu): Add (#221)
laichengyu Apr 13, 2018
655c6a0
Version 1.5rc released (#224)
ewaldhew Apr 13, 2018
e5d701e
#92 SortCommand feature (#209)
neilish3re Apr 13, 2018
98ecd48
Refactor CommandList (#227)
laichengyu Apr 13, 2018
44517cd
MainApp: Fix rulebook init (#228)
ewaldhew Apr 14, 2018
c1161ab
Refactor CommandList (#231)
laichengyu Apr 14, 2018
25c246e
[#223] Notifications jump to coin (#232)
ewaldhew Apr 14, 2018
ac3aa71
NotifyCommand: Fix amount change condition matching (#229)
ewaldhew Apr 14, 2018
11a3f39
[#225] Sync data on app startup (#230)
laichengyu Apr 14, 2018
11ecdf3
[#226] Add coin icons to panels (#233)
laichengyu Apr 14, 2018
37aa619
Reduce icon db to 100 items (#239)
laichengyu Apr 14, 2018
e121998
Fix Rule Actions (#240)
ewaldhew Apr 14, 2018
2aa57cd
[#126] Add loading ui (#241)
laichengyu Apr 14, 2018
53d69fb
Update dev guide, user guide and PPP (#234)
neilish3re Apr 14, 2018
4987787
Add UrlBuilderTests (#242)
laichengyu Apr 14, 2018
e2ea134
Notifications: Add tests (#243)
ewaldhew Apr 14, 2018
b0f86ec
Amount: Disallow negative, Better print (#244)
ewaldhew Apr 14, 2018
3670543
Add authorship (#246)
laichengyu Apr 14, 2018
a541e8c
Add FetchUtil tests (#245)
laichengyu Apr 14, 2018
5c6f2b7
MainApp: Add tests (#249)
laichengyu Apr 14, 2018
c55008c
SyncCommand: Add tests (#247)
laichengyu Apr 14, 2018
63305b1
Remove unused methods (#248)
laichengyu Apr 14, 2018
d76ff01
Notification Conditions: Fix calculations, Remove useless (#250)
ewaldhew Apr 15, 2018
948c58c
Attempt to fix coveralls badge (#253)
laichengyu Apr 15, 2018
40f0708
Edit Async fetch comments (#251)
laichengyu Apr 15, 2018
dc16761
[#57] Charts Panel (#256)
ewaldhew Apr 15, 2018
2d53f8c
UGDG/PPP(laichengyu): Update (#259)
laichengyu Apr 15, 2018
df4c76d
DevGuide update (#261)
laichengyu Apr 15, 2018
4110863
Documentation updates (Notifications) (#260)
ewaldhew Apr 15, 2018
02ad6f1
Update User Guide, Dev Guide and PPP (#257)
neilish3re Apr 15, 2018
0ae352a
Fix UG typos (#264)
laichengyu Apr 15, 2018
1aab1a7
Beautify App (#263)
ewaldhew Apr 15, 2018
f2ea6c3
Include sync feature in DG (#266)
laichengyu Apr 15, 2018
9ad2d77
Final edits (#267)
ewaldhew Apr 15, 2018
794dcbd
SyncCommand: Prevent crash when internet connection out (#268)
ewaldhew Apr 15, 2018
af3937c
Final PPP (#269)
ewaldhew Apr 15, 2018
42fe647
Fill in final missing documentation (#270)
ewaldhew Apr 15, 2018
d5062fe
Version 1.5 released (#271)
ewaldhew Apr 15, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fill in final missing documentation (se-edu#270)
ewaldhew authored and eldon-chung committed Apr 15, 2018
commit 42fe6471e6e0fae6a7fe4df45305ead684a86873
6 changes: 3 additions & 3 deletions docs/AboutUs.adoc
Original file line number Diff line number Diff line change
@@ -14,17 +14,17 @@ We are a team based in the http://www.comp.nus.edu.sg[School of Computing, Natio
image::eldon-chung.png[width="150", align="left"]
{empty}[https://github.com/Eldon-Chung[github]] [<<eldon-chung#, portfolio>>]

Role: Developer +
Role: Developer, Algorithms +
Responsibilities: Documentation, Logic, Testing

'''

=== Ewald Hew
=== Hew Yih Shiuan Ewald
image::ewaldhew.png[width="150", align="left"]
{empty}[http://github.com/ewaldhew[github]] [<<ewaldhew#, portfolio>>]

Role: Developer, Scheduling and tracking +
Responsibilities: UI
Responsibilities: UI, Notifications

'''

17 changes: 17 additions & 0 deletions docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
@@ -1482,3 +1482,20 @@ Expected: The notification list window should open, and any added notification r
.. Test case: `notify p/>1`, `sync` +
Click on any notification. +
Expected: The coin stated on the notification is opened in the detail window, and its price history chart and subreddit page can be seen.

=== Syncing Coin Data

. Running the sync

.. Test case: `sync` +
Expected: The latest prices are fetched, as mentioned in the previous section F.5.

=== Sorting Coin List

. Sorting in Lexicographical Order

.. Prerequisites: Multiple coins in the list
.. Test case: `order` +
Expected: The coins should be sorted by their trading codes alphabetically.
.. Test case: `order z` +
Expected: The coins should be sorted in reverse order, again by trading codes.