-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated vsix to vsix3 for Visual Studio 2017 #8 #20
Conversation
Do we have a statement in the readme or elsewhere about what verisons of VS are supported? If so, we should test on all those versions or announce a breaking change if some no longer work. The updating of the version right in the master branch is not how we do our major packages, but since this is a simple single-assembly extension, it seems reasonable to do it this way. |
I would like to hold off on releasing this until we can confirm that the binding redirects have been fixed. To be safe, should we also hold off merging until then? |
@rprouse Since I don't know what the binding redirects are actually about, I defer to your judgement. 😄 |
@rprouse Yes, I think so. But .... see below |
Since this only allows us to work in VS 15, I think we should hold off until we know it works. It may be a Microsoft bug, but it is us who ends up looking bad. |
@rprouse I agree. This isn't a critical package. |
@OsirisTerje - I added a commit for nunit/nunit3-vs-adapter#268 to this branch, to avoid merge conflicts when this is merged. Hope that's ok. |
There have been a few updates to VS 2017 RC since we started this issue. We should confirm that the binding redirects have been fixed. |
This is now ready for release. @rprouse , @CharliePoole |
The VSIX is updated to format vsix3, ref #8
Testing is done for VS 15 (vnext), but needs to be done for VS 2015 too before merging.