Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vsix to vsix3 for Visual Studio 2017 #8 #20

Merged
merged 5 commits into from
Mar 7, 2017
Merged

Conversation

OsirisTerje
Copy link
Member

The VSIX is updated to format vsix3, ref #8

Testing is done for VS 15 (vnext), but needs to be done for VS 2015 too before merging.

@CharliePoole
Copy link
Member

Do we have a statement in the readme or elsewhere about what verisons of VS are supported? If so, we should test on all those versions or announce a breaking change if some no longer work.

The updating of the version right in the master branch is not how we do our major packages, but since this is a simple single-assembly extension, it seems reasonable to do it this way.

@rprouse
Copy link
Member

rprouse commented Nov 12, 2016

I would like to hold off on releasing this until we can confirm that the binding redirects have been fixed. To be safe, should we also hold off merging until then?

@CharliePoole
Copy link
Member

@rprouse Since I don't know what the binding redirects are actually about, I defer to your judgement. 😄

@OsirisTerje
Copy link
Member Author

@rprouse Yes, I think so. But .... see below
@CharliePoole We found there are 4 missing binding redirects, to MIcrosoft assemblies, in the Visual Studio devenv.exe.config. The MS people have been informed and confirmed they will get these in. We build to the earliest version, VS 2015 in this case, and the redirects are needed to make it work in VS 15 (vNext).
So, it is not really up to us. We could release, and then it is up to MS if it will work in VS 15 or not.

@rprouse
Copy link
Member

rprouse commented Nov 12, 2016

Since this only allows us to work in VS 15, I think we should hold off until we know it works. It may be a Microsoft bug, but it is us who ends up looking bad.

@CharliePoole
Copy link
Member

@rprouse I agree. This isn't a critical package.

@ChrisMaddock
Copy link
Member

@OsirisTerje - I added a commit for nunit/nunit3-vs-adapter#268 to this branch, to avoid merge conflicts when this is merged. Hope that's ok.

@rprouse
Copy link
Member

rprouse commented Jan 2, 2017

There have been a few updates to VS 2017 RC since we started this issue. We should confirm that the binding redirects have been fixed.

@OsirisTerje OsirisTerje changed the title Updated vsix to vsix3 for Visual Studio 15 #8 Updated vsix to vsix3 for Visual Studio 2017 #8 Mar 5, 2017
@OsirisTerje
Copy link
Member Author

This is now ready for release. @rprouse , @CharliePoole
I have also updated the license info, #22 , as per discussion
It has to be a new vsix, so the vsix manifest ID has been changed.
I have also made release notes and made an installation section under docs.

@OsirisTerje OsirisTerje merged commit 06ef768 into master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants