Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform integration tests on packages #38

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Perform integration tests on packages #38

merged 1 commit into from
Mar 31, 2020

Conversation

CharliePoole
Copy link
Member

Fixes #37

@CharliePoole CharliePoole requested a review from a team March 24, 2020 19:08
@CharliePoole
Copy link
Member Author

Note: I had hopes that this would allow us to build on Linux, but that's not the case. More work is needed on this on it's own separate issue. The Travis build shows as pending, but you can ignore it.

Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

private void ClearDriverExtensions()
{
// Delay in case a prior test run is holding open assemblies we want to delete
System.Threading.Thread.Sleep(1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying, but 🙄

😄

@CharliePoole CharliePoole merged commit 1adff36 into master Mar 31, 2020
@CharliePoole CharliePoole deleted the issue-37 branch March 31, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run integration tests on packages
2 participants