[WIP] [DO NOT MERGE] Multi-target NUnit Project Loader #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ChrisMaddock
commented
Mar 30, 2018
| foreach(var framework in TARGET_FRAMEWORKS) | ||
| { | ||
| NUnit3(System.IO.Path.Combine(BIN_DIR, framework, UNIT_TEST_ASSEMBLY)); | ||
| } |
There was a problem hiding this comment.
I wanted to do this by passing the solution file, but nunit/vs-project-loader#26 😞
|
Closing this, it's been over 2 years, and there isn't a lot of progress here anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough spike as to what multi-targeting one of our extensions might look like. It's more to help with the implementation of nunit/nunit-console#394, than to be merged at this point.
I picked the nunit-project-loader, as I think it's the only extension we'd potentially want to directly multi-target as .NET 2.0, and .NET Standard - if we do have future functionality to load .NET Standard extensions. Basis: the vs-project-loader we'd ideally want to do via MSBuild, and the nunit2 extensions I'm hoping will be used less over time. It currently targets net20/net45, as we need a .NET Standard version of nunit.engine.api before we can build .NET Standard extensions. (It would be simple to later swap
net45tonetstandard10however!)Feedback on structure welcome. Things I'm aware of: