Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile to the project to allow building on Linux #716

Merged
merged 3 commits into from
Jan 1, 2020

Conversation

rprouse
Copy link
Member

@rprouse rprouse commented Dec 20, 2019

Fixes #453

This removes the dependency on my external docker image by adding the Dockerfile to this repository. The first build is slow because it must download and build the image, but after that it is just as quick as on Windows.

The docker image that is built is close to the build images that we use in Azure DevOps except that it uses a new version of Mono.

Copy link
Member

@ChrisMaddock ChrisMaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

I’ll give this a try next time I’m on a desktop. 😊 (also - I presume the .deb file shouldn’t be committed?)

@ChrisMaddock
Copy link
Member

Turns out I don't have premium-enough Windows to install Docker any more, but let's get this merged. 🙂 Rob - I've pushed another commit to git-ignore the deb file, hope you don't mind. Will merge once CI has passed. 🙂

@ChrisMaddock ChrisMaddock merged commit aa095dd into master Jan 1, 2020
@ChrisMaddock ChrisMaddock deleted the docker branch January 1, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-mono-docker.ps1 fails to run out the box
2 participants