Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md, fix Rider line #816

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jchesshirAspire
Copy link
Contributor

@jchesshirAspire jchesshirAspire commented Oct 19, 2023

The last line in the Visual Studio Code section clearly belongs in the section after it, unless the author mean to say "Visual Studio Code has built-in...."

Proposing this change under the former assumption

Resolves #815

The last line in the Visual Studio Code section clearly belongs in the section after it, unless the author mean to say "Visual Studio Code has built-in...."

Proposing this change under the former assumption.
@OsirisTerje OsirisTerje self-requested a review October 19, 2023 18:51
Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct! Thanks! :-)

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge as soon as the CLA is signed.

@SeanKilleen SeanKilleen enabled auto-merge (squash) October 19, 2023 19:01
@jchesshirAspire
Copy link
Contributor Author

@dotnet-policy-service agree company="Aspire Software"

@SeanKilleen SeanKilleen merged commit 30b3cc8 into nunit:master Oct 20, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
The last line in the Visual Studio Code section clearly belongs in the section after it, unless the author mean to say "Visual Studio Code has built-in...."

Proposing this change under the former assumption. 30b3cc8
@jchesshirAspire jchesshirAspire deleted the patch-1 branch October 20, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propose moving text to what appears to be the proper section.
4 participants