💄(testimonies) new content impacting view: scroll through testimonies #30
Conversation
|
What you propose is acceptable for a first iteration. My suggestion might be a bit "hacky" and requiring too much JS for smth that could be done in pure HTML and CSS as you propose. Let's discuss it |
|
I discussed it with @johann, he would prefer the latter suggestion. |
|
Done! And now with keyboard nav we can read all testimonies (was missing). testimonies.mp4 |
manuhabitela
force-pushed
the
new-testimonies
branch
3 times, most recently
from
a00d079 to
4462a05
Compare
manuhabitela
force-pushed
the
new-testimonies
branch
from
4462a05 to
09e18b6
Compare
|
|
manuhabitela
force-pushed
the
new-testimonies
branch
from
09e18b6 to
39f0101
Compare
manuhabitela
requested review from
lebaudantoine
and removed request for
lebaudantoine
| @@ -20,7 +20,10 @@ interface CardProps { | |||
| } | |||
|
|
|||
| const Card = ({ title, quote, img, entity }: CardProps) => ( | |||
| <div className="flex flex-col bg-white p-7 text-left flex-1"> | |||
| <div | |||
| tabIndex={0} | |||
There was a problem hiding this comment.
nit: when navigating using tab, the pagination disappears.
There was a problem hiding this comment.
Yeah it's that way for everytime we have this behavior. Could be improved for sure but the important thing is we can access everything.
add two new testimonies, making the layout needing more space so they fit. change UI logic on desktop: always use swiper, just show more slides at the same time.
we tend to try to click them, lets just make them work. No need to make them keyboard accessible from my point of view: having tabindexes on items seems better UX (will have to test a bit more with screen readers to be sure).
now keyboard users can view every testimony
manuhabitela
force-pushed
the
new-testimonies
branch
from
39f0101 to
28d0778
Compare
since we're not sure on the actually wanted layout in figma I just made the wrapping div of testimonies overflow, styled a bit the scrollbar, and made it so that mouse users can "scroll" easily.
i guess this is acceptable for now and we change when we get specific layout info?
Peek.2024-03-21.18-32.mp4