Small misc updates #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuhabitela
force-pushed
the
small-updates
branch
3 times, most recently
from
17e075c to
8466591
Compare
this seems to better fit what we actually want in most cases
- remove the big bottom padding at the end of the page that was a bit weird? I feel like it's more of a figma design thing to better view stuff than the actual thing we want… lets match DSFR - stick the footer at the bottom of the page when there is not enough content
design loosely based on figma design, but changed a bit to better fit this site layout. The figma design seems copied from desk app, here fontsizes are bigger and all…
- also match the .logo bg logic with .logo-footer to resolve a UI bug (logo was not rendered at 0px on the x axis because of weird background-size issue)
following Sabine feedback
+ add better user feedback on custom digitalcommon links
just follow the figma design here (based on newsletter button)
update wording to match figma design
manuhabitela
force-pushed
the
small-updates
branch
from
5e45ccc to
d0761d5
Compare
manuhabitela
force-pushed
the
small-updates
branch
from
d0761d5 to
a1db217
Compare
|
Looks like this now:
|
add new variant option to button component to be able to easily create the outline buttons
manuhabitela
force-pushed
the
small-updates
branch
from
a1db217 to
43b335e
Compare
lebaudantoine
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement latest team feedback.
Proposal
One thing to note is I intentionally changed how the footer is handled: