Set up a minimal CI #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
force-pushed
the
init-ci
branch
17 times, most recently
from
05866e2 to
59f7670
Compare
lebaudantoine
requested review from
manuhabitela
and removed request for
manuhabitela
manuhabitela
approved these changes
Mar 6, 2024
manuhabitela
approved these changes
Mar 6, 2024
It's a general good practice to pin dependencies, to make Developer setup reproducible, and on pair with CI tools. Additionaly, to avoid updating manually every dependencies, set-up renovate bot, that will open a PR every week to automatically update deps.
Enhance Prettier configs. It now runs only on all ts, tsx, md, json, cjs, js sources. Its configs are declared under prettierrc.json file. Some sources are ignored, please take a look at .prettierignore Follow Next.js documentation to configure Prettier along with the default ESLint linter.
Add default template files. The pull request template contains two sections: - Purpose - Proposal The issues templates are for: - Bug report - Feature request - Support questions
Add first Github workflow, which lints git commits. Make sure the title and body respect team's rule, using a Python package, GitLint, which was extended with a custom rule. This workaround is copy/paste from people repo. It might be refactored in a near futur in a clean Github action, instead of duplicating the logic. A step has been added to look for fixup commits in git log's output. It's not handled natively by the GitLint Python package.
Add a new job that ensure that all code sources pass ESLint lint rules, Prettier lint rules, and we can build the static output from code sources. It makes sure we maintain a high code quality, and that merging code into the main branch won't result in error in Scalingo deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Maintain high quality code standards + Improve DX while reviewing code
Proposal
Set up a minimal CI configuration which will lint git commits, code sources, and build static sources.
Also, we will maintain dependencies up-to-date using renovate bot.
As soon as the PR is merged, I will set up these two jobs as required to merge any PR.