Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAE6286 project: Compact finite difference schemes #2

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

shantanu7
Copy link

Hi Prof. Barba

This is my submission for the course project. Please let me know if you have any recommendations/ suggestions so I can improve this work before the deadline.

Thank you,
Shantanu.

@ncclementi
Copy link
Member

Hey Shantanu, I've read you project, it is really interesting. Here are some suggestions:

  • In this report ----> In this notebook (to be consistent with previous notebook)

  • for some reason nbviewer is not rendering this line:

    where: \begin{equation} 0 \leq x, y \leq 1 \end{equation}

    try using $ $

  • Is there a reason why you put an image of the countour plots of u and laplacian
    of u instead of the code that generates them? I think it would be better to have the code.

  • How you obtain the Pade scheme for f_xx ? I'm not following how you get it from the
    explanation in the section "Conducting a Pade scheme", because you explained for
    the first derivative. If you get it from another place, can you explain a little bit more about it?

  • It will help a lot if you add docstrings in the functions, as we did in the notebooks for the class.

typo : conamination ---> contamination

@shantanu7
Copy link
Author

Hey Naty,

Thanks for the feedback. Shall I make the changes and update the document on github? Do you want the changes today or can I make them over the weekend?

Shantanu

@labarba
Copy link
Member

labarba commented Dec 17, 2015

You can make updates whenever you want. I won't be merging any pull requests until I go over all the projects, and it will take a while!

@shantanu7
Copy link
Author

Hi Naty, Prof. Barba:

I've made the changes that you suggested earlier this week. Particularly I included the derivation for the second order derivative formulation. Could you go check it out and let me know what you think of it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants