feature: 팔로우/채팅 알림 기능 추가 #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcm 토큰을 관리하기 위해 redis를 사용
publisher: 이벤트 발생 listener: 발생한 이벤트를 처리
5 tasks
seongho-joo
requested changes
May 22, 2022
|
|
||
| public String getBody(Long memberId) { | ||
| return memberId + this.body; | ||
| } |
There was a problem hiding this comment.
id보다는 username이 더 나을 것 같습니다!
ch0213
approved these changes
May 22, 2022
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum FcmEventDomain { |
There was a problem hiding this comment.
클래스 이름을 FcmEvent로 하는건 어떨까요? 도메인이라기 보다는 이벤트 타입인 것 같습니다!
| try (InputStream inputStream = new ByteArrayInputStream(configStringValue.getBytes(StandardCharsets.UTF_8))) { | ||
| List<FirebaseApp> apps = FirebaseApp.getApps(); | ||
|
|
||
| if (Objects.isNull(apps) || apps.isEmpty()) { |
There was a problem hiding this comment.
Objects.isNull()은 Predicate로 사용하기 위한 메서드입니다! apps == null로 비교하면 될 것 같아요.
| private final FcmTokenService fcmTokenService; | ||
|
|
||
| @PostMapping("/fcm-token") | ||
| public CommonResponse saveFcmToken(@LoginUser Member member, @RequestHeader("fcm-token") String fcm) { |
There was a problem hiding this comment.
CommomResponse<Void>로 고쳐야 할 것 같습니다.
|
아직 프론트에서 코드 구성이 안됐다면 이 pr은 서버 안 올려도 될 것 같습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Motivation
❗ Key changes
✏️ To Reviewers