Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conversations chat UI. #398

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Jan 28, 2025

What does this do?

This work makes major changes to the Chat response UI allowing for threaded conversations that are held in context through a conversationRef. A few updates have occurred to accommodate this change and iterate towards more complex multi question/answer responses.

  1. useChatSocket is now handled at lower level component. This allows each question/answer to interact independently when receiving messages. Although indepdenent of each when receiving/sending messages, only one connection should be made at page level. This connection should sustain unless it times out.

const { authToken, isConnected, message, sendMessage } = useChatSocket();

  1. The feedback form is now tied to each response. Note that the form UI is in place, however, the submission of this form and it's question/responses is not yet functional. Functionality for this will be handled in a new issue.

  2. The more results table for hybrid search is hidden currently. This will be handled in a new issue and may require refinement before resolving.

  3. We are not currently sending questions/answers to a higher level search context as we did previously. I have not yet determined if we need this search context any longer and what shape this should be. Solutions for (2) and (3) above should determine how we handle this. Tests related to mocking this context have temporally been removed.

Review steps

This can be reviewed in amplify at https://preview-5354-conversations-ui.dc.rdc-staging.library.northwestern.edu/ or if run in a dev environment. If running in dev, be sure to set NEXT_PUBLIC_DCAPI_ENDPOINT to https://dcapi-prototype.rdc-staging.library.northwestern.edu/api/v2

image

@mathewjordan mathewjordan changed the base branch from deploy/staging to preview/conversations January 28, 2025 13:52
@mathewjordan mathewjordan force-pushed the preview/5354-conversations-ui branch from 6f9c3b4 to 6abbce2 Compare January 28, 2025 13:57
@mathewjordan mathewjordan changed the title preview/5354 conversations ui Handle conversations DC chat UI. Jan 28, 2025
@mathewjordan mathewjordan changed the title Handle conversations DC chat UI. Handle conversations chat UI. Jan 28, 2025
@mathewjordan mathewjordan self-assigned this Jan 28, 2025
@mathewjordan mathewjordan marked this pull request as ready for review January 28, 2025 14:45
@mathewjordan mathewjordan force-pushed the preview/5354-conversations-ui branch from 29f2c38 to 2dfe42e Compare January 28, 2025 16:08
Copy link
Contributor

@kdid kdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@charlesLoder charlesLoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icons are chefs' kiss

@mathewjordan mathewjordan force-pushed the preview/5354-conversations-ui branch from 2dfe42e to 465f892 Compare January 29, 2025 20:57
@mathewjordan mathewjordan merged commit 6713868 into preview/conversations Jan 29, 2025
2 checks passed
@mathewjordan mathewjordan deleted the preview/5354-conversations-ui branch January 29, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants