Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common IIIF share component. #388

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Nov 8, 2024

What does this do?

This work adds a View as IIIF dropdown component to the Search, individual Work, and individual Collection screens. The location of this dropdown has been commonly placed in the upper right of the each of these screens. To accommodate this addition, there are many CSS adjustments along with minor layout changes made to normalize these screen and to promote white space and normalize style treatments.

  • Creation of new Shared/IIIF/Share.tsx component (the dropdown)
  • Addition of <IIIFShare /> to Screens
  • Styling changes across screens
  • Creation of iiifSearchUri() helper for converting current search page NextRouter query to an ?as=iiif URI.
  • Updates DC API types package to 2.6.0 for iiif_collection property

Search screen

image

Work screen

image

Collection screen

image

How should we review?

This can be reviewed at:
https://preview-add-iiif-share-component.d2v1qbdeix3nr2.amplifyapp.com

Things to consider:

  • Do selected Facets on search screens translate properly to the IIIF URL
  • Are we good with styling adjustments?

@mathewjordan mathewjordan mentioned this pull request Nov 8, 2024
@mathewjordan mathewjordan self-assigned this Nov 8, 2024
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liked the green check when clicking the copy button! 😀
SCR-20241108-ijvz

@mathewjordan
Copy link
Member Author

Really liked the green check when clicking the copy button! 😀 SCR-20241108-ijvz

It's those little things... 😀

@mathewjordan mathewjordan merged commit 59350a9 into deploy/staging Nov 8, 2024
6 checks passed
@mathewjordan mathewjordan deleted the preview/add-iiif-share-component branch November 8, 2024 16:03
kdid pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants