Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize page head and OG data for SEO #312

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

adamjarling
Copy link
Contributor

@adamjarling adamjarling commented Feb 22, 2024

What does this do?

  • Small refactor of how we are rendering consistent values to <title />, <meta name="description" content="..." />, and Open Graph data.
  • Prepends Work and Collection item title to page <title /> tag.
  • Updates best practices on applying Open Graph values.
  • Implements a const helper to hold values related to page <head /> meta` values.
  • Adds a Github Action to run unit tests on branch pushes (capture any Amplify build failures early).

image

How to test

Scroll through the site, and inspect the above elements for consistency, default values, and specific values for dynamic route pages.

@adamjarling adamjarling self-assigned this Feb 22, 2024
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than that .vscode file.

Comment on lines 3 to 4
"source.fixAll": "explicit",
"source.organizeImports": "never"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we intentionally started including this file. Should we be still?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I couldn't remember. At some point, to keep lengthy imports in files to be organized in a sane way, I think we might have tried to sync our settings. I'll remove this and if it becomes an annoying issue moving forward we can tackle it.

"og:title":
"Hawking dental products in outdoor market, Cuernavaca, Mexico - Digital Collections - Libraries - Northwestern University",
"Hawking dental products in outdoor market, Cuernavaca, Mexico",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

… app

Upgrade deps

Normalize <head /> title, meta, and open graph values to be consistent and follow best practices

Add a constants file to help organize head meta values

Stop tracking .vscode directory
@adamjarling adamjarling force-pushed the 4519-title-seo-update branch 4 times, most recently from 34346e3 to cea4b25 Compare February 23, 2024 15:33
@adamjarling adamjarling force-pushed the 4519-title-seo-update branch from cea4b25 to 99119b2 Compare February 23, 2024 16:25
@adamjarling adamjarling merged commit 780e206 into deploy/staging Feb 23, 2024
1 check passed
@adamjarling adamjarling deleted the 4519-title-seo-update branch August 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants