-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize page head and OG data for SEO #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than that .vscode
file.
.vscode/settings.json
Outdated
"source.fixAll": "explicit", | ||
"source.organizeImports": "never" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we intentionally started including this file. Should we be still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I couldn't remember. At some point, to keep lengthy imports in files to be organized in a sane way, I think we might have tried to sync our settings. I'll remove this and if it becomes an annoying issue moving forward we can tackle it.
"og:title": | ||
"Hawking dental products in outdoor market, Cuernavaca, Mexico - Digital Collections - Libraries - Northwestern University", | ||
"Hawking dental products in outdoor market, Cuernavaca, Mexico", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
… app Upgrade deps Normalize <head /> title, meta, and open graph values to be consistent and follow best practices Add a constants file to help organize head meta values Stop tracking .vscode directory
34346e3
to
cea4b25
Compare
cea4b25
to
99119b2
Compare
What does this do?
<title />
,<meta name="description" content="..." />
, and Open Graph data.title
to page<title />
tag.<head />
meta` values.How to test
Scroll through the site, and inspect the above elements for consistency, default values, and specific values for dynamic route pages.