Merge pull request #253 from nulib/3435-facet-group-labels

Update language of facet groups.
nulib · Mar 16, 2023 · 58c5eb2 · 58c5eb2
2 parents cc6a5b4 + 7a94151
commit 58c5eb2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/components/Facets/Filter/GroupList.test.tsx b/components/Facets/Filter/GroupList.test.tsx
@@ -91,8 +91,9 @@ describe("FacetsGroupList component", () => {
   it("renders facet aggregations when a facet is clicked upon", async () => {
     const user = userEvent.setup();
     renderHelper();
+    await user.click(screen.getByText("Subject and Descriptive"));
 
-    const sAndDEl = await screen.findByText("Subjects and Descriptive");
+    const sAndDEl = await screen.findByText("Subject and Descriptive");
     await user.click(sAndDEl);
 
     const el = await screen.findByText("Genre");

diff --git a/lib/constants/facets-model.ts b/lib/constants/facets-model.ts
@@ -167,16 +167,11 @@ export const FACETS_DESCRIPTIVE: FacetsGroup = {
       label: "Work Type",
     },
   ],
-  label: "Subjects and Descriptive",
+  label: "Subject and Descriptive",
 };
 
 export const FACETS_LOCATION: FacetsGroup = {
   facets: [
-    {
-      field: "library_unit",
-      id: "libraryDepartment",
-      label: "Library Department",
-    },
     {
       field: "collection.title",
       id: "collection",
@@ -197,13 +192,18 @@ export const FACETS_LOCATION: FacetsGroup = {
       id: "folderNumber",
       label: "Folder Number",
     },
+    {
+      field: "library_unit",
+      id: "libraryDepartment",
+      label: "Library Department",
+    },
   ],
-  label: "Location",
+  label: "Collection and Location",
 };
 
 export const FACETS: FacetsGroup[] = [
   FACETS_DESCRIPTIVE,
-  FACETS_CREATOR,
   FACETS_LOCATION,
+  FACETS_CREATOR,
   FACETS_RIGHTS_USAGE,
 ];