Skip to content

Commit

Permalink
Timeout :(
Browse files Browse the repository at this point in the history
  • Loading branch information
mathewjordan committed Sep 16, 2024
1 parent afd4c6e commit 4a455b3
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
1 change: 1 addition & 0 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
run: npx playwright test
env:
BASE_URL: ${{ secrets.BASE_URL }}
NEXT_PUBLIC_DCAPI_ENDPOINT: ${{ secrets.NEXT_PUBLIC_DCAPI_ENDPOINT }}

- uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
Expand Down
1 change: 0 additions & 1 deletion pages/items/[id].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ const WorkPage: NextPage<WorkPageProps> = ({
title={work?.title || ""}
description={work ? buildWorkDescription(work) : ""}
>
<div data-testid="example-toss">{id}</div>
{!isLoading && work && manifest && (
<WorkProvider initialState={{ manifest: manifest, work: work }}>
<ErrorBoundary FallbackComponent={ErrorFallback}>
Expand Down
8 changes: 4 additions & 4 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ export default defineConfig({
fullyParallel: false,

/* Increase locator timeout past default 5s */
expect: {
timeout: 30000,
},
// expect: {
// timeout: 30000,
// },
/* Fail the build on CI if you accidentally left test.only in the source code. */
forbidOnly: !!process.env.CI,
reporter: "html",
timeout: 30000,
// timeout: 30000,
/* Retry on CI only */
retries: process.env.CI ? 2 : 0,
/* Opt out of parallel tests on CI. */
Expand Down
3 changes: 0 additions & 3 deletions tests/work.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ test.describe("Work page component", async () => {
});

test("renders the Work top level metadata", async ({ page, workPage }) => {
await expect(page.getByTestId("example-toss")).toContainText(
CANARY_WORK_ID,
);
await expect(page.getByTestId("title")).toContainText(
canaryWork.title || "",
);
Expand Down

0 comments on commit 4a455b3

Please sign in to comment.