Skip to content

Commit

Permalink
Wire up Home Open Graph test check, and Layout super nav links tests
Browse files Browse the repository at this point in the history
  • Loading branch information
adamjarling committed Mar 28, 2024
1 parent 45f4710 commit 4585d2c
Show file tree
Hide file tree
Showing 11 changed files with 724 additions and 516 deletions.
20 changes: 14 additions & 6 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,21 @@
"prettier"
],
"overrides": [
// Only uses Testing Library lint rules in test files
// // Only uses Testing Library lint rules in test files
// {
// "files": [
// "**/__tests__/**/*.[jt]s?(x)",
// "**/?(*.)+(spec|test).[jt]s?(x)"
// ],
// "extends": ["plugin:testing-library/react"]
// },

// Overrides for Playwright tests
{
"files": [
"**/__tests__/**/*.[jt]s?(x)",
"**/?(*.)+(spec|test).[jt]s?(x)"
],
"extends": ["plugin:testing-library/react"]
"files": ["tests/**/*.[jt]s?(x)"],
"rules": {
"testing-library/prefer-screen-queries": "off"
}
}
],
"rules": {
Expand Down
1 change: 1 addition & 0 deletions components/Header/Super.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
Super,
User,
} from "@/components/Header/Header.styled";

import Container from "../Shared/Container";
import { DCAPI_ENDPOINT } from "@/lib/constants/endpoints";
import Link from "next/link";
Expand Down
2 changes: 1 addition & 1 deletion components/Nav/Nav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface NavProps {
}

const Nav: React.FC<NavProps> = ({ children }) => {
return <NavStyled>{children}</NavStyled>;
return <NavStyled data-testid="super-nav">{children}</NavStyled>;
};

export default Nav;
1 change: 1 addition & 0 deletions components/Shared/SVG/Northwestern.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const NorthwesternWordmark: React.FC = () => (
<svg
version="1.1"
id="nortwestern-wordmark"
data-testid="northwestern-logo"
xmlns="http://www.w3.org/2000/svg"
xmlnsXlink="http://www.w3.org/1999/xlink"
x="0px"
Expand Down
Loading

0 comments on commit 4585d2c

Please sign in to comment.